You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6e8f112
Browse filesBrowse the repository at this point in the historyBrowse files
starboard/nplb: Fold nplb_evergreen_compat_tests into nplb proper (youtube#4946)
This is a follow-up to youtube#4831, rolling `nplb_evergreen_compat_tests` into
`nplb` proper.
Run via `./out/linux-x64x11_devel/nplb
--gtest_filter=*CrashpadConfigTest*:*SabiTest*:*ExecutableMemoryTest*:*MaxFileNameTest*:*StorageTest*:*LoaderAppMetricsTest:*FontsTest*`
--
Two sets of test failed on my Linux and needed attention:
- `CrashpadConfigTest.VerifyUploadCert` was IIUC broken due to an
extra `...app/cobalt/content...` path manually added to the cert
location. Looking at the GN `ssl:copy_ssl_certificates` target, it
seems to agree with `GetCACertificatesPath()` in that the extra path
is not needed. Discussing this with @y4vor, we decided to add a new
helper target `copy_ssl_certificates_evergreen` to put the certs
in the right spot.
- `FontsTest.*` needed `deps` on `fonts:copy_font_data` GN targets
(both `data_deps` and `deps`). This worked, but I had to comment
out the `install_content = true` statements in that BUILD.gn (it's
unclear whether this would break other things). Said GN target
uses `exec_script` and needs an exception in //.gn, this CL adds
that too.
Asides from it, some unnecessary test classes are removed, and some
preprocessor logic simplified.
Bug: b/384819454
0 commit comments