Skip to content

ci: fix windows CRLF on binary builds, cargo-shuttle 0.57.1#2118

Merged
jonaro00 merged 4 commits intomainfrom
ci/windows-crlf
Sep 11, 2025
Merged

ci: fix windows CRLF on binary builds, cargo-shuttle 0.57.1#2118
jonaro00 merged 4 commits intomainfrom
ci/windows-crlf

Conversation

@jonaro00
Copy link
Member

No description provided.

@jonaro00 jonaro00 merged commit fa04c67 into main Sep 11, 2025
1 of 23 checks passed
@jonaro00 jonaro00 deleted the ci/windows-crlf branch September 11, 2025 14:39
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR addresses Windows-specific build issues by implementing a comprehensive fix for CRLF (Carriage Return Line Feed) line ending problems. The changes include two key components:

  1. CI/CD Pipeline Fix: Updates the CircleCI Windows build job to configure Git line endings properly by setting core.autocrlf input, clearing the Git cache, and performing a hard reset to ensure all files use Unix-style LF line endings. Additionally, all PowerShell commands are explicitly configured to use powershell.exe for consistency.

  2. Version Bump: Increments the cargo-shuttle version from 0.57.0 to 0.57.1, marking this as a patch release that addresses the Windows compatibility issues.

This fix directly addresses a known issue documented in the repository's DEVELOPING.md file, where Windows systems can introduce CRLF line endings that break shell scripts and build processes expecting Unix-style LF endings. The solution ensures cross-platform compatibility by standardizing line endings in the CI environment, which is critical for a project like Shuttle that needs to build reliably across different operating systems. The patch version increment follows semantic versioning conventions, indicating a backward-compatible bug fix that resolves platform-specific build failures for Windows users.

Important Files Changed

Changed Files
Filename Score Overview
cargo-shuttle/Cargo.toml 5/5 Version bump from 0.57.0 to 0.57.1 for patch release
.circleci/config.yml 5/5 Added Git line ending configuration and explicit PowerShell shell specification for Windows builds

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it addresses a well-documented Windows compatibility issue
  • Score reflects thorough implementation of a known fix with proper version increment and targeted CI changes
  • No files require special attention as both changes are straightforward and follow established patterns

2 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant