ci: fix windows CRLF on binary builds, cargo-shuttle 0.57.1#2118
ci: fix windows CRLF on binary builds, cargo-shuttle 0.57.1#2118
Conversation
There was a problem hiding this comment.
Greptile Summary
This PR addresses Windows-specific build issues by implementing a comprehensive fix for CRLF (Carriage Return Line Feed) line ending problems. The changes include two key components:
-
CI/CD Pipeline Fix: Updates the CircleCI Windows build job to configure Git line endings properly by setting
core.autocrlf input, clearing the Git cache, and performing a hard reset to ensure all files use Unix-style LF line endings. Additionally, all PowerShell commands are explicitly configured to usepowershell.exefor consistency. -
Version Bump: Increments the
cargo-shuttleversion from 0.57.0 to 0.57.1, marking this as a patch release that addresses the Windows compatibility issues.
This fix directly addresses a known issue documented in the repository's DEVELOPING.md file, where Windows systems can introduce CRLF line endings that break shell scripts and build processes expecting Unix-style LF endings. The solution ensures cross-platform compatibility by standardizing line endings in the CI environment, which is critical for a project like Shuttle that needs to build reliably across different operating systems. The patch version increment follows semantic versioning conventions, indicating a backward-compatible bug fix that resolves platform-specific build failures for Windows users.
Important Files Changed
Changed Files
| Filename | Score | Overview |
|---|---|---|
| cargo-shuttle/Cargo.toml | 5/5 | Version bump from 0.57.0 to 0.57.1 for patch release |
| .circleci/config.yml | 5/5 | Added Git line ending configuration and explicit PowerShell shell specification for Windows builds |
Confidence score: 5/5
- This PR is safe to merge with minimal risk as it addresses a well-documented Windows compatibility issue
- Score reflects thorough implementation of a known fix with proper version increment and targeted CI changes
- No files require special attention as both changes are straightforward and follow established patterns
2 files reviewed, no comments
No description provided.