Skip to content

fix(cargo-shuttle): windows build#2116

Merged
jonaro00 merged 1 commit intoshuttle-hq:mainfrom
jonaro00:fix/windows-build
Sep 11, 2025
Merged

fix(cargo-shuttle): windows build#2116
jonaro00 merged 1 commit intoshuttle-hq:mainfrom
jonaro00:fix/windows-build

Conversation

@jonaro00
Copy link
Member

No description provided.

@jonaro00 jonaro00 merged commit eccf1e9 into shuttle-hq:main Sep 11, 2025
1 of 23 checks passed
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes a critical Windows build error in the cargo-shuttle CLI tool's local run functionality. The issue was in the local_run method where the Windows-specific signal handling code was incorrectly trying to call runtime.wait() instead of child.wait(). This variable reference error would have prevented the Windows build from compiling successfully.

The fix aligns the Windows code path with the existing Unix implementation, ensuring both platforms correctly wait on the spawned child process (either a runtime executable or Docker container). This change maintains the existing signal handling logic while resolving the compilation error, allowing Shuttle's CLI to build and function properly on Windows systems.

Important Files Changed

Changed Files
Filename Score Overview
cargo-shuttle/src/lib.rs 5/5 Fixed Windows build error by correcting variable reference from runtime.wait() to child.wait() in signal handling code

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it fixes a clear compilation error
  • Score reflects a straightforward bug fix that aligns Windows code with working Unix implementation
  • No files require special attention as the change is isolated and well-understood

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@jonaro00 jonaro00 deleted the fix/windows-build branch September 11, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant