fix(cargo-shuttle): windows build#2116
Conversation
There was a problem hiding this comment.
Greptile Summary
This PR fixes a critical Windows build error in the cargo-shuttle CLI tool's local run functionality. The issue was in the local_run method where the Windows-specific signal handling code was incorrectly trying to call runtime.wait() instead of child.wait(). This variable reference error would have prevented the Windows build from compiling successfully.
The fix aligns the Windows code path with the existing Unix implementation, ensuring both platforms correctly wait on the spawned child process (either a runtime executable or Docker container). This change maintains the existing signal handling logic while resolving the compilation error, allowing Shuttle's CLI to build and function properly on Windows systems.
Important Files Changed
Changed Files
| Filename | Score | Overview |
|---|---|---|
| cargo-shuttle/src/lib.rs | 5/5 | Fixed Windows build error by correcting variable reference from runtime.wait() to child.wait() in signal handling code |
Confidence score: 5/5
- This PR is safe to merge with minimal risk as it fixes a clear compilation error
- Score reflects a straightforward bug fix that aligns Windows code with working Unix implementation
- No files require special attention as the change is isolated and well-understood
1 file reviewed, no comments
No description provided.