refa(cargo-shuttle): find binary target based on macro in source#2059
Merged
refa(cargo-shuttle): find binary target based on macro in source#2059
Conversation
oddgrd
approved these changes
Jun 13, 2025
oddgrd
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Now finds the package and binary target for local runs and deployments by looking in the target's source file for a
#[shuttle_runtime::mainstring. (no]so that#[shuttle_runtime::main(...)]can be found)Also passes
--bintocargo buildandbinary_nameto deployment args.✔️ Gets rid of the requirement that the target (binary) name of the Shuttle service has to match the crate name :)
✔️ Sets us up to add
-p/--packageand--binargs to build/run/deploy commands.How has this been tested? (if applicable)
Intergration tests were added and adjusted for the changes, and local run and deploy was manually tested (works the same way).