Skip to content

Commit bb651f0

Browse files
morningmanclaude
andcommitted
[fix](test) pin variant session defaults for idempotent show-create round-trip in check_before_quit
A property-less variant column renders bare 'variant' only when default_variant_max_subcolumns_count == 0 (VariantType.toSql), and the recreate parser bakes the current session default into the column. The per-connection fuzzer randomized these defaults, making the CREATE -> recreate -> show-create round-trip non-idempotent for 7 variant tables. Pin the two fuzzed variant session defaults to 0 in the check connection. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
1 parent 46e4fa2 commit bb651f0

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

‎regression-test/suites/check_before_quit/check_before_quit.groovy‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,14 @@ suite("check_before_quit", "nonConcurrent,p0") {
247247

248248
sql "set enable_decimal256 = true;"
249249
sql "set enable_variant_flatten_nested = true;"
250+
// Pin the fuzzed variant session defaults so the CREATE -> recreate round-trip below
251+
// is idempotent. A property-less variant column renders bare `variant` only when
252+
// default_variant_max_subcolumns_count == 0 (VariantType.toSql), and the recreate
253+
// parser bakes the current session default into the column. The per-connection
254+
// session-variable fuzzer randomizes these, which would otherwise make a bare-variant
255+
// origin re-render with PROPERTIES and break the round-trip comparison.
256+
sql "set default_variant_max_subcolumns_count = 0;"
257+
sql "set default_variant_sparse_hash_shard_count = 0;"
250258
sql """
251259
ADMIN SET ALL FRONTENDS CONFIG ('enable_inverted_index_v1_for_variant' = 'true');
252260
"""

0 commit comments

Comments
 (0)