Skip to content

Commit 8a076ce

Browse files
committed
[fix](case) fix insert_group_commit_into_max_filter_ratio
1 parent 9d3c35b commit 8a076ce

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎regression-test/suites/insert_p0/insert_group_commit_into_max_filter_ratio.groovy‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ suite("insert_group_commit_into_max_filter_ratio") {
170170
// async mode, sync mode, off mode
171171
sql """ truncate table ${tableName} """
172172
connect(context.config.jdbcUser, context.config.jdbcPassword, context.config.jdbcUrl) {
173+
sql """ set enable_strict_cast = false; """
173174

174175
sql """ set group_commit = sync_mode; """
175176
group_commit_insert """ insert into ${dbTableName} values (1, 'a', 10); """, 1
@@ -183,15 +184,15 @@ suite("insert_group_commit_into_max_filter_ratio") {
183184
sql """ set enable_insert_strict = false; """
184185
group_commit_insert """ insert into ${dbTableName} values (5, 'abc', 10); """, 0
185186

186-
// The row 6 and 7 is different between legacy and nereids
187187
try {
188188
sql """ set group_commit = off_mode; """
189-
sql """ set enable_insert_strict = true; """
189+
sql """ set enable_strict_cast = true; """
190190
sql """ insert into ${dbTableName} values (6, 'a', 'a'); """
191191
} catch (Exception e) {
192192
logger.info("exception: " + e)
193193
assertTrue(e.toString().contains("can't cast"))
194194
}
195+
sql """ set enable_strict_cast = false; """
195196

196197
try {
197198
sql """ set group_commit = off_mode; """
@@ -210,7 +211,7 @@ suite("insert_group_commit_into_max_filter_ratio") {
210211
sql """ set group_commit = async_mode; """
211212
sql """ set enable_insert_strict = false; """
212213
group_commit_insert """ insert into ${dbTableName} values (9, 'a', 'a'); """, 1
213-
get_row_count_with_retry(8)
214+
get_row_count_with_retry(7)
214215
order_qt_sql """ select * from ${dbTableName} """
215216
}
216217
sql """ truncate table ${tableName} """

0 commit comments

Comments
 (0)