Skip to content

Support inheritable insecure request policy in documents and workers#1

Merged
shubhamg13 merged 1 commit intoshubhamg13:unsecurefrom
jdm:unsecure
Jan 17, 2025
Merged

Support inheritable insecure request policy in documents and workers#1
shubhamg13 merged 1 commit intoshubhamg13:unsecurefrom
jdm:unsecure

Conversation

@jdm
Copy link
Copy Markdown

@jdm jdm commented Jan 17, 2025

These changes allow the /upgrade-insecure-requests tests for XHR, Fetch, <img>, and workers to pass. Websockets fail due to servo#35028, and tests that rely on iframes fail because of the missing step about nested contexts.

@jdm
Copy link
Copy Markdown
Author

jdm commented Jan 17, 2025

I don't have any privileges in this repo, so you will need to do the approving and merging.

@shubhamg13 shubhamg13 merged commit 897ad6e into shubhamg13:unsecure Jan 17, 2025
shubhamg13 pushed a commit that referenced this pull request Oct 14, 2025
…ns (servo#39544)

Script: added ```line_no``` as argument to both
```fetch_inline_module_script()``` & ```compile_module_script()``` to
fix the inline script reporting wrong line issue
([servo#39415](servo#39415)).

Originally, the function ```compile_module_script()``` hardwires the
value 1 when invoking ```CompileOptionsWrapper::new()```. This is fine
if the script is written in separate JS file, but for inline scripts, it
will cause confusion if the ```<script>``` tag doesn't start from line
#1.

```line_no``` is obtained from ```line_number```, a member variable from ```HTMLScriptElement```. 

Credits to @jdm for actually pointing out which functions to fix.

Testing: Created a WPT test for this change, specifically: ```tests/wpt/tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-5.html```.

Fixes: issue [servo#39415](servo#39415)

---------

Signed-off-by: RichardTjokroutomo <[email protected]>
Signed-off-by: Rocketjumper <[email protected]>
Co-authored-by: Josh Matthews <[email protected]>
Co-authored-by: Euclid Ye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants