Support inheritable insecure request policy in documents and workers#1
Merged
shubhamg13 merged 1 commit intoshubhamg13:unsecurefrom Jan 17, 2025
Merged
Support inheritable insecure request policy in documents and workers#1shubhamg13 merged 1 commit intoshubhamg13:unsecurefrom
shubhamg13 merged 1 commit intoshubhamg13:unsecurefrom
Conversation
5 tasks
aeeedee to
578dbe7
Compare
shubhamg13
approved these changes
Jan 17, 2025
…workers. Signed-off-by: Josh Matthews <[email protected]>
Author
|
I don't have any privileges in this repo, so you will need to do the approving and merging. |
shubhamg13
pushed a commit
that referenced
this pull request
Oct 14, 2025
…ns (servo#39544) Script: added ```line_no``` as argument to both ```fetch_inline_module_script()``` & ```compile_module_script()``` to fix the inline script reporting wrong line issue ([servo#39415](servo#39415)). Originally, the function ```compile_module_script()``` hardwires the value 1 when invoking ```CompileOptionsWrapper::new()```. This is fine if the script is written in separate JS file, but for inline scripts, it will cause confusion if the ```<script>``` tag doesn't start from line #1. ```line_no``` is obtained from ```line_number```, a member variable from ```HTMLScriptElement```. Credits to @jdm for actually pointing out which functions to fix. Testing: Created a WPT test for this change, specifically: ```tests/wpt/tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-5.html```. Fixes: issue [servo#39415](servo#39415) --------- Signed-off-by: RichardTjokroutomo <[email protected]> Signed-off-by: Rocketjumper <[email protected]> Co-authored-by: Josh Matthews <[email protected]> Co-authored-by: Euclid Ye <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow the /upgrade-insecure-requests tests for XHR, Fetch,
<img>, and workers to pass. Websockets fail due to servo#35028, and tests that rely on iframes fail because of the missing step about nested contexts.