chore: keep updated with maven 4 rc-2 consumer pom changes #377
+31
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lprimak
force-pushed
the
fix-build-pom-access
branch
from
e98f1d1 to
f2f9803
Compare
lprimak
force-pushed
the
fix-build-pom-access
branch
from
f2f9803 to
1d8e66a
Compare
lprimak
force-pushed
the
fix-build-pom-access
branch
from
1d8e66a to
121e033
Compare
lprimak
changed the title
Contributor
Author
|
@petrberan This can be merged first, when you come back from vacation, thank yoU! |
Contributor
Author
|
@petrberan Can we start with merging this one? Thank you! |
Member
|
Hi @lprimak , terribly sorry for the delay! Truth is that after my arrival from PTO there were blocking issues with some critical infrastructure and then some work reorganization and each week I've tried to tackle Shrinkwrap issues, without much success. But I'll make sure to prioritize it next week, at least these PRs and new branch so you're not held back by my absence. Thank you for your patience though! |
petrberan
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven release 4.0.0-rc-2 changed how consumer POM is generated.
new option
maven.consumer.pom=trueis necessary to make ShrinkWrap work prior to the PR,and take full advantage of maven 4 features in the future.