Skip to content

Conversation

@petrberan
Copy link
Member

@petrberan petrberan requested a review from xstefank November 29, 2023 16:44
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the parentheses, please

return false;
}
return true;
return (packaging.equals(other.packaging));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outer () not needed

}
return true;
return other.groupId == null;
} else return (groupId.equals(other.groupId));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@petrberan
Copy link
Member Author

Fixed everywhere

@petrberan petrberan force-pushed the SHRINKRES-320 branch 2 times, most recently from eb3fce7 to d477dd9 Compare December 1, 2023 14:35
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petrberan petrberan merged commit 9b436f9 into shrinkwrap:master Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants