-
Notifications
You must be signed in to change notification settings - Fork 84
[SHRINKRES-320] Resolve control flow issues #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xstefank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the parentheses, please
| return false; | ||
| } | ||
| return true; | ||
| return (packaging.equals(other.packaging)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outer () not needed
| } | ||
| return true; | ||
| return other.groupId == null; | ||
| } else return (groupId.equals(other.groupId)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
307ada3 to
f1d4fe7
Compare
|
Fixed everywhere |
eb3fce7 to
d477dd9
Compare
xstefank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d477dd9 to
67e5c5c
Compare
https://issues.redhat.com/browse/SHRINKRES-320