[SHRINKRES-316] Clean up the poms #180
Conversation
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
There is an enormous duplication. Maybe in future we could generate these files.
| <dependency> | ||
| <groupId>org.codehaus.plexus</groupId> | ||
| <artifactId>plexus-compiler-javac</artifactId> | ||
| <version>${version.org.codehaus.plexus.compiler.javac}</version> |
There was a problem hiding this comment.
Wouldn't it be better to keep it version.package.of.dependency?
| <dependency> | ||
| <groupId>org.jboss.shrinkwrap</groupId> | ||
| <artifactId>shrinkwrap-bom</artifactId> | ||
| <version>${version.org.jboss.shrinkwrap}</version> |
petrberan
force-pushed
the
SHRINKRES-316
branch
from
9b6f2ca to
08bfa6b
Compare
|
Wrong commit, will resolve tomorrow |
petrberan
force-pushed
the
SHRINKRES-316
branch
from
08bfa6b to
afb57fd
Compare
|
Fixed |
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
I find it hard to believe you need to have a separate version for every artifact. Align what you can.
| <groupId>org.gradle</groupId> | ||
| <artifactId>gradle-tooling-api</artifactId> | ||
| <version>${version.gradle-tooling-api}</version> | ||
| <version>${version.org.gradle.gradle-tooling-api}</version> |
There was a problem hiding this comment.
I still think you should go with package, not package.artifact. If we will have some automation in the future we should align this with what you will have in main pom.xml
There was a problem hiding this comment.
Having problem understanding what is the desired outcome for this comment. Can you provide expected version property for - for example - arquillian-spacelift-api?
| <format>html</format> | ||
| <format>xml</format> | ||
| </formats> | ||
| <check/> |
There was a problem hiding this comment.
Check tag is required by the plugin config, in this case it doesn't do anything. This tag makes IDEA not consider it an error anymore
| <version.org.codehaus.plexus.plexus-classworlds>2.7.0</version.org.codehaus.plexus.plexus-classworlds> | ||
| <version.org.codehaus.plexus.plexus-compiler-javac>2.7</version.org.codehaus.plexus.plexus-compiler-javac> | ||
| <version.org.codehaus.plexus.plexus-component-annotations>2.1.0</version.org.codehaus.plexus.plexus-component-annotations> | ||
| <version.org.codehaus.plexus.plexus-sec-dispatcher>2.0</version.org.codehaus.plexus.plexus-sec-dispatcher> |
There was a problem hiding this comment.
Try to align versions where you can from the same projects.
There was a problem hiding this comment.
The goal of this issue is to clean up the poms, updating versions will be part of the future development
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
After @petrberan explained to me that he plans to finish remaining comments in a followup issue. I'm merging this.
petrberan
force-pushed
the
SHRINKRES-316
branch
from
afb57fd to
3e09348
Compare
2 participants
https://issues.redhat.com/browse/SHRINKRES-316