Repository navigation
Commit a6570c3
authored
Previously, this method was not mocked and would return an undefined
value when it was called in the `BufferBindingsGLESTest` unit tests.
When the returned value happened to be false, this makes the tests fail.
We've seen this failure pop up multiple times recently.
Examples:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_unopt/47431/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_unopt/47434/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_unopt/19763/overview
I can't consistently repro the failure at HEAD or at the PRs which
produced the example failures. But I I tested that modifying this PR to
return `GL_FALSE` instead of `GL_TRUE` does consistently reproduce the
failure.
1 parent 0968ec9 commit a6570c3
3 files changed
Lines changed: 13 additions & 0 deletions
File tree
- engine/src/flutter/impeller/renderer/backend/gles
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
290 | 290 | | |
291 | 291 | | |
292 | 292 | | |
| 293 | + | |
| 294 | + | |
293 | 295 | | |
294 | 296 | | |
295 | 297 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
358 | 358 | | |
359 | 359 | | |
360 | 360 | | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
361 | 368 | | |
362 | 369 | | |
363 | 370 | | |
| |||
561 | 568 | | |
562 | 569 | | |
563 | 570 | | |
| 571 | + | |
| 572 | + | |
564 | 573 | | |
565 | 574 | | |
566 | 575 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| 105 | + | |
105 | 106 | | |
106 | 107 | | |
107 | 108 | | |
| |||
277 | 278 | | |
278 | 279 | | |
279 | 280 | | |
| 281 | + | |
280 | 282 | | |
281 | 283 | | |
282 | 284 | | |
| |||
0 commit comments