fix: Missing undefined array key checks in HookableBusinessEvent (backport: 6.7.8.x)#15518
Merged
Michael Telgmann (mitelg) merged 2 commits into6.7.8.xfrom Mar 12, 2026
Merged
Conversation
shopware-octo-sts-app
bot
added
component/core
domain/framework
shopware-octo-sts-app
bot
requested review from
Simon Fiebranz (CR0YD),
Dennis Garding (DennisGarding),
Susanne Hartung (ennasus4sun),
Andrii Havryliuk (h1k3r),
Jozsef Damokos (jozsefdamokos),
Jonas Elfering (keulinho),
Michael Telgmann (mitelg),
Nicolas Fortier (nfortier-shopware),
Umut Dogan (umutdogan4291) and
Nikolas Evers (vintagesucks)
github-actions
bot
added
external-contribution
OpenAPI Snapshotℹ️ shopware/store-api — schema identical to base trunk📋 Additional Information
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 6.7.8.x #15518 +/- ##
==========================================
Coverage ? 56.58%
==========================================
Files ? 3002
Lines ? 92480
Branches ? 0
==========================================
Hits ? 52328
Misses ? 40152
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Michael Telgmann (mitelg)
approved these changes
Mar 12, 2026
Michael Telgmann (mitelg)
removed
the
external-contribution
Jonas Elfering (keulinho)
approved these changes
Mar 12, 2026
Nikolas Evers (vintagesucks)
approved these changes
Mar 12, 2026
Michael Telgmann (mitelg)
force-pushed
the
fix/undefined-array-key-backport-6.7.8.x
branch
from
05d98a3 to
683bca7
Compare
Nicolas Fortier (nfortier-shopware)
approved these changes
Mar 12, 2026
Michael Telgmann (mitelg)
deleted the
fix/undefined-array-key-backport-6.7.8.x
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #15420
Resolves: #15395
1. Why is this change necessary?
Due to the refactoring of removing the usage of
emptyit can now happen, that an undefined array key access is happening in theHookableBusinessEvent. (see PR https://github.com/shopware/shopware/pull/15042/changes#diff-805d7e1aa3994187a04e7a6b72cc75ab40ef9f46e90d344909a5e961f269728dR64-R65 )2. What does this change do, exactly?
Use
??operator to initialise the variables correctly.3. Describe each step to reproduce the issue or behaviour.
Execute the
HookableBusinessEventTestwith therestrictWarningssetting in thephpunit.xml.distset tofalse. Warnings about undefined array key will appear, like described in the linked issue.4. Please link to the relevant issues (if any).
5. Checklist
RELEASE_INFO-6.<major>.mdunder “Upcoming” for informational changes, including the consequences of the change and how it affects external developers.UPGRADEsection inUPGRADE-6.<next-major>.mdfor breaking changes (what/why/impact/how to adapt).