fix: Missing undefined array key checks in HookableBusinessEvent#15420
Merged
Michael Telgmann (mitelg) merged 2 commits intotrunkfrom Mar 10, 2026
Merged
fix: Missing undefined array key checks in HookableBusinessEvent#15420Michael Telgmann (mitelg) merged 2 commits intotrunkfrom
Michael Telgmann (mitelg) merged 2 commits intotrunkfrom
Conversation
Michael Telgmann (mitelg)
requested review from
a team,
Andrii Havryliuk (h1k3r),
Jonas Elfering (keulinho),
Nicolas Fortier (nfortier-shopware),
Soner (shyim) and
Umut Dogan (umutdogan4291)
Michael Telgmann (mitelg)
added
component/core
domain/framework
Michael Telgmann (mitelg)
requested review from
Simon Fiebranz (CR0YD),
Dennis Garding (DennisGarding),
Malte Janz (MalteJanz),
Susanne Hartung (ennasus4sun),
Jozsef Damokos (jozsefdamokos),
Lars Kemper (larskemper) and
Nikolas Evers (vintagesucks)
and removed request for
a team
|
OpenAPI Snapshotℹ️ shopware/store-api — schema identical to base trunkℹ️ shopware/admin-api — schema identical to base trunk |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #15420 +/- ##
==========================================
- Coverage 57.15% 57.14% -0.01%
==========================================
Files 3011 3011
Lines 94076 94085 +9
==========================================
+ Hits 53765 53766 +1
- Misses 40311 40319 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lars Kemper (larskemper)
approved these changes
Mar 9, 2026
Malte Janz (MalteJanz)
approved these changes
Mar 9, 2026
Arens Myzyri (arens-myz)
approved these changes
Mar 9, 2026
Michael Telgmann (mitelg)
force-pushed
the
fix/undefined-array-key
branch
from
1e7f42b to
ce4e933
Compare
Michael Telgmann (mitelg)
force-pushed
the
fix/undefined-array-key
branch
from
ce4e933 to
60d4e04
Compare
Michael Telgmann (mitelg)
added
the
backport-6.7.8.x
5 tasks
Michael Telgmann (mitelg)
added a commit
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
Due to the refactoring of removing the usage of
emptyit can now happen, that an undefined array key access is happening in theHookableBusinessEvent. (see PR https://github.com/shopware/shopware/pull/15042/changes#diff-805d7e1aa3994187a04e7a6b72cc75ab40ef9f46e90d344909a5e961f269728dR64-R65 )2. What does this change do, exactly?
Use
??operator to initialise the variables correctly.3. Describe each step to reproduce the issue or behaviour.
Execute the
HookableBusinessEventTestwith therestrictWarningssetting in thephpunit.xml.distset tofalse. Warnings about undefined array key will appear, like described in the linked issue.4. Please link to the relevant issues (if any).
5. Checklist
RELEASE_INFO-6.<major>.mdunder “Upcoming” for informational changes, including the consequences of the change and how it affects external developers.UPGRADEsection inUPGRADE-6.<next-major>.mdfor breaking changes (what/why/impact/how to adapt).