fix: use correct delimiter in refresh migration command#15211
Merged
Jonas Elfering (keulinho) merged 3 commits intotrunkfrom Feb 26, 2026
Merged
fix: use correct delimiter in refresh migration command#15211Jonas Elfering (keulinho) merged 3 commits intotrunkfrom
Jonas Elfering (keulinho) merged 3 commits intotrunkfrom
Conversation
Jonas Elfering (keulinho)
added
component/core
domain/framework
|
tests/unit/Core/Framework/Migration/Command/RefreshMigrationCommandTest.php
Show resolved
Hide resolved
OpenAPI Snapshotℹ️ shopware/store-api — schema identical to base trunkℹ️ shopware/admin-api — schema identical to base trunk |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #15211 +/- ##
==========================================
+ Coverage 56.44% 56.47% +0.02%
==========================================
Files 2997 2997
Lines 92403 92397 -6
==========================================
+ Hits 52157 52177 +20
+ Misses 40246 40220 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Michael Telgmann (mitelg)
approved these changes
Feb 25, 2026
tests/unit/Core/Framework/Migration/Command/RefreshMigrationCommandTest.php
Outdated
Show resolved
Hide resolved
Umut Dogan (umutdogan4291)
approved these changes
Feb 26, 2026
| static::assertInstanceOf(MigrationStep::class, $migration); | ||
| $newTimestamp = $migration->getCreationTimestamp(); | ||
| // assert that the new timestamp is within 3 second of the current time, to account for any slight delays in execution | ||
| static::assertEqualsWithDelta(time(), $newTimestamp, 3); |
Contributor
There was a problem hiding this comment.
Self-note: if this gets flaky, replace with $this->assertGreaterThanOrEqual($startTime, $newTimestamp);
and set $startTime = time(); at the beginning of the test
Contributor
Author
There was a problem hiding this comment.
yep could do, however i wanted also to have a upper bound
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #14904
1. Why is this change necessary?
Regex was wrong because suddenly we have two delimiters
2. What does this change do, exactly?
Fix the regex and add tests
3. Describe each step to reproduce the issue or behaviour.
see issue
4. Please link to the relevant issues (if any).
#14904