Skip to content

fix: missing exclude regulation price extension when encoding calculated price#14874

Merged
Phung Nguyen (rittou) merged 3 commits intotrunkfrom
fix/missing-exclude-regulation-price-extension-when-encoding-calculated-price
Feb 11, 2026
Merged

fix: missing exclude regulation price extension when encoding calculated price#14874
Phung Nguyen (rittou) merged 3 commits intotrunkfrom
fix/missing-exclude-regulation-price-extension-when-encoding-calculated-price

Conversation

@rittou
Copy link
Copy Markdown
Contributor

@rittou Phung Nguyen (rittou) commented Feb 10, 2026 •
edited
Loading

1. Why is this change necessary?

This pull request adds support for handling the RegulationPrice property in the CalculatedPriceFieldSerializer, ensuring it is properly encoded and decoded alongside existing price properties.

2. What does this change do, exactly?

Fix to CalculatedPrice serialization:

  • Added import and handling for the RegulationPrice struct in CalculatedPriceFieldSerializer.php, ensuring it is included during both encoding and decoding processes [1] [2].
  • Updated the encode method to strip extensions from the regulationPrice field, similar to how it's done for listPrice.

3. Describe each step to reproduce the issue or behaviour.

  • Create a product that has a regulated price
  • Add that product to the cart
  • Check out with that cart -> Errors would be there

4. Please link to the relevant issues (if any).

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have updated developer-facing release notes if this change is relevant for external developers:
    • Add a short entry to RELEASE_INFO-6.<major>.md under “Upcoming” for informational changes, including the consequences of the change and how it affects external developers.
    • Add an UPGRADE section in UPGRADE-6.<next-major>.md for breaking changes (what/why/impact/how to adapt).
    • See the Documenting a Release Process for details.
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfilled them

@rittou Phung Nguyen (rittou) self-assigned this Feb 10, 2026
@rittou Phung Nguyen (rittou) added the domain/inventory Responsible for managing products and everything product-related label Feb 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 10, 2026

Warnings
⚠️ The Pull Request doesn't contain any release info, if your changes are relevant for external developers please add an entry to the release info file, including the consequences of the change and how it affects external developers. For detailed infos please refer to the [release documentation guide](https://github.com/shopware/shopware/blob/trunk/delivery-process/documenting-a-release.md).

@explore-openapi
Copy link
Copy Markdown

explore-openapi bot commented Feb 10, 2026 •
edited
Loading

OpenAPI Snapshot

Project: shopware/store-api

No changes detected

Your OpenAPI schema is identical to the base branch (trunk).

Links:
All Project Snapshots · Base Branch Snapshot

Project: shopware/admin-api

No changes detected

Your OpenAPI schema is identical to the base branch (trunk).

Links:
All Project Snapshots · Base Branch Snapshot

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.83%. Comparing base (e911711) to head (6e37942).
⚠️ Report is 2 commits behind head on trunk.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk   #14874      +/-   ##
==========================================
+ Coverage   55.72%   55.83%   +0.10%     
==========================================
  Files        2976     2976              
  Lines       91671    91678       +7     
==========================================
+ Hits        51084    51188     +104     
+ Misses      40587    40490      -97
Flag Coverage Δ
phpunit-migration 92.17% <ø> (ø)
phpunit-unit 53.32% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rittou Phung Nguyen (rittou) force-pushed the fix/missing-exclude-regulation-price-extension-when-encoding-calculated-price branch from 72f6594 to f6397af Compare February 10, 2026 11:13
@rittou Phung Nguyen (rittou) changed the title fix: missing exclude regulation price extension when encoding calcula… fix: missing exclude regulation price extension when encoding calculated price Feb 10, 2026
@rittou Phung Nguyen (rittou) marked this pull request as ready for review February 10, 2026 14:26
@rittou Phung Nguyen (rittou) added this pull request to the merge queue Feb 11, 2026
Merged via the queue into trunk with commit 263e281 Feb 11, 2026
97 of 99 checks passed
@rittou Phung Nguyen (rittou) deleted the fix/missing-exclude-regulation-price-extension-when-encoding-calculated-price branch February 11, 2026 03:25
@github-actions github-actions bot added this to the 6.7.8.0 milestone Feb 11, 2026
shopware-octo-sts-app-2 bot pushed a commit that referenced this pull request Feb 11, 2026
@rittou
fix: missing exclude regulation price extension when encoding calcula…
fe9194d 
…ted price (#14874)
@shopware-octo-sts-app-2 shopware-octo-sts-app-2 bot mentioned this pull request Feb 11, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vienthuong Vin Le (vienthuong) vienthuong approved these changes

@tamvt Tam Vo (tamvt) tamvt approved these changes

Assignees

@rittou Phung Nguyen (rittou)

Labels

backport-6.6.x domain/inventory Responsible for managing products and everything product-related milestone/6.7.8.0

Projects

None yet

Milestone

6.7.8.0

Development

Successfully merging this pull request may close these issues.

Cart line item is missing regulation price

3 participants

@rittou @vienthuong @tamvt