fix: Profiler: use $title as key in start() so it will correctly be unset in stop() (backport: 6.6.x)#14613
Merged
Nicolas Fortier (nfortier-shopware) merged 1 commit into6.6.xfrom Feb 16, 2026
Conversation
…nset in stop() (#14019) Co-authored-by: Nicolas Fortier <[email protected]> Co-authored-by: Nicolas Fortier <[email protected]>
shopware-octo-sts-app
bot
added
component/core
domain/framework
shopware-octo-sts-app
bot
requested review from
Martin Bens (SpiGAndromeda) and
Nicolas Fortier (nfortier-shopware)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 325068c4bc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
Nicolas Fortier (nfortier-shopware)
approved these changes
Jan 29, 2026
Nicolas Fortier (nfortier-shopware)
requested a review
from Andrii Havryliuk (h1k3r)
Michael Telgmann (mitelg)
requested changes
Jan 30, 2026
Michael Telgmann (mitelg)
approved these changes
Jan 30, 2026
Andrii Havryliuk (h1k3r)
approved these changes
Jan 30, 2026
Nicolas Fortier (nfortier-shopware)
deleted the
bugfix/profiler-start-stop-backport-6.6.x
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #14019
1. Why is this change necessary?
When using
Profiler::start()andProfiler::stop()separately a LogicException will be thrown duringProfiler::cleanup()as it thinks it still has an open trace. This happens becauseProfiler::start()stores the title as a value in$openTracesbutProfiler::stop()tries to use the title as a key.2. What does this change do, exactly?
Prevents a LogicException from occuring during shutdown when using Profiler start/stop separately
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist
RELEASE_INFO-6.<major>.mdunder “Upcoming” for informational changes, including the consequences of the change and how it affects external developers.UPGRADEsection inUPGRADE-6.<next-major>.mdfor breaking changes (what/why/impact/how to adapt).