Skip to content

ci: resolve winget releases without checkout#1473

Merged
shm11C3 merged 1 commit into
developfrom
ci/fix-winget-release-repo-resolution
May 6, 2026
Merged

ci: resolve winget releases without checkout#1473
shm11C3 merged 1 commit into
developfrom
ci/fix-winget-release-repo-resolution

Conversation

@shm11C3

@shm11C3 shm11C3 commented May 6, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

  • Pass --repo $env:GITHUB_REPOSITORY to gh release view in the WinGet submission workflow
  • Fix manual workflow runs where gh cannot infer the repository because the job does not checkout the repo

Validation

  • Ran actionlint against .github/workflows/winget.yml
  • Verified gh release view v1.8.0 --repo shm11C3/HardwareVisualizer --json assets finds HardwareVisualizer_1.8.0_x64_en-US.msi

Summary by CodeRabbit

  • Chores
    • Updated Winget release workflow to explicitly specify repository context when fetching release information, improving workflow reliability and consistency across different execution environments.

Copilot AI review requested due to automatic review settings May 6, 2026 07:16
@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label May 6, 2026
@coderabbitai

coderabbitai Bot commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ee938a39-9ea3-44ca-a8c8-314f63b620b2

📥 Commits

Reviewing files that changed from the base of the PR and between f8fb8b5 and 7679241.

📒 Files selected for processing (1)
  • .github/workflows/winget.yml
📝 Walkthrough

Walkthrough

Two gh release view commands in the Winget release workflow are updated to explicitly specify the repository via --repo $env:GITHUB_REPOSITORY. This ensures the commands operate on the correct repository context without relying on implicit defaults.

Changes

Explicit Repository Specification

Layer / File(s) Summary
GitHub Actions Workflow
.github/workflows/winget.yml		 Both gh release view invocations (lines 52–56 and 73) now include --repo $env:GITHUB_REPOSITORY to explicitly scope tag resolution and asset fetching to the current repository.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • shm11C3/HardwareVisualizer#1472: Both PRs modify the same .github/workflows/winget.yml release-metadata resolution logic — this PR adds explicit --repo flags to the gh release view calls introduced by the related PR.

Suggested labels

bug, github_actions

Poem

🐰 With whiskers twitched and hop so true,
We scope our releases, old made new!
No ambient repos shall lead astray,
Explicit paths show GitHub the way. ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/fix-winget-release-repo-resolution

Comment @coderabbitai help to get the list of available commands and usage tips.

@shm11C3 shm11C3 merged commit 79915ca into develop May 6, 2026
34 of 35 checks passed
@shm11C3 shm11C3 deleted the ci/fix-winget-release-repo-resolution branch May 6, 2026 07:17
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 95.06% (🎯 60%) 1234 / 1298
🔵 Statements 94.62% (🎯 60%) 1303 / 1377
🔵 Functions 96.27% (🎯 60%) 310 / 322
🔵 Branches 88.03% (🎯 60%) 456 / 518
File CoverageNo changed files found.
Generated in workflow #2953 for commit 7679241 by the Vitest Coverage Report Action

Copilot AI reviewed May 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WinGet submission workflow to make gh release view explicitly target the current repository, so manual workflow_dispatch runs work even when the job doesn’t check out the repo (and gh can’t infer the default repo).

Changes:

  • Pass --repo $env:GITHUB_REPOSITORY when resolving the latest release tag via gh release view.
  • Pass --repo $env:GITHUB_REPOSITORY when fetching release assets to locate the MSI by name.

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Rust Tauri Coverage Report

Coverage Details 
Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
_tests/commands/background_image_test.rs          39                 0   100.00%           6                 0   100.00%          21                 0   100.00%           0                 0         -
_tests/commands/settings_test.rs                 220                 0   100.00%          18                 0   100.00%         165                 0   100.00%           0                 0         -
adapters/tray.rs                                 127               127     0.00%          14                14     0.00%          87                87     0.00%           0                 0         -
adapters/window.rs                               254                69    72.83%          21                 8    61.90%         195                47    75.90%           0                 0         -
app/startup.rs                                   188                87    53.72%          10                 3    70.00%         114                58    49.12%           0                 0         -
commands/background_image.rs                      22                 7    68.18%          11                 5    54.55%          19                 7    63.16%           0                 0         -
commands/hardware.rs                              62                62     0.00%          20                20     0.00%          68                68     0.00%           0                 0         -
commands/settings.rs                             616               616     0.00%         108               108     0.00%         528               528     0.00%           0                 0         -
commands/system.rs                                21                21     0.00%          10                10     0.00%          20                20     0.00%           0                 0         -
commands/ui.rs                                    17                17     0.00%           2                 2     0.00%          13                13     0.00%           0                 0         -
commands/updater.rs                               97                97     0.00%          15                15     0.00%          66                66     0.00%           0                 0         -
enums/error.rs                                   101                10    90.10%           8                 1    87.50%          86                10    88.37%           0                 0         -
enums/hardware.rs                                184                 7    96.20%          15                 1    93.33%         111                 6    94.59%           0                 0         -
enums/settings.rs                                386                16    95.85%          23                 2    91.30%         253                10    96.05%           0                 0         -
infrastructure/database/migration.rs              66                 1    98.48%          10                 0   100.00%          86                 0   100.00%           0                 0         -
lib.rs                                           225               225     0.00%           6                 6     0.00%         143               143     0.00%           0                 0         -
lifecycle.rs                                     254               205    19.29%          31                27    12.90%         186               163    12.37%           0                 0         -
main.rs                                            3                 3     0.00%           1                 1     0.00%           3                 3     0.00%           0                 0         -
models/hardware.rs                               375                83    77.87%          31                12    61.29%         275               100    63.64%           0                 0         -
models/hardware_archive.rs                         8                 0   100.00%           2                 0   100.00%          10                 0   100.00%           0                 0         -
models/settings.rs                               285                 0   100.00%          16                 0   100.00%         252                 0   100.00%           0                 0         -
services/background_image_service.rs             165                96    41.82%          16                10    37.50%          93                59    36.56%           0                 0         -
services/gpu_service.rs                           56                56     0.00%          11                11     0.00%          43                43     0.00%           0                 0         -
services/hardware_service.rs                      85                85     0.00%           4                 4     0.00%          51                51     0.00%           0                 0         -
services/language_service.rs                     101                 0   100.00%          18                 0   100.00%          57                 0   100.00%           0                 0         -
services/memory_service.rs                        12                12     0.00%           3                 3     0.00%           7                 7     0.00%           0                 0         -
services/motherboard_service.rs                   12                12     0.00%           3                 3     0.00%           7                 7     0.00%           0                 0         -
services/network_service.rs                       14                14     0.00%           1                 1     0.00%           8                 8     0.00%           0                 0         -
services/settings_service.rs                     340               156    54.12%          33                15    54.55%         284               142    50.00%           0                 0         -
services/system_service.rs                        22                22     0.00%           2                 2     0.00%          12                12     0.00%           0                 0         -
services/ui_service.rs                            45                45     0.00%           8                 8     0.00%          36                36     0.00%           0                 0         -
tray/surface/mod.rs                                8                 8     0.00%           2                 2     0.00%           5                 5     0.00%           0                 0         -
tray/surface/tauri_surface.rs                     80                80     0.00%           6                 6     0.00%          48                48     0.00%           0                 0         -
tray/widget.rs                                   601                 5    99.17%          51                 1    98.04%         533                 3    99.44%           0                 0         -
utils/color.rs                                    66                 1    98.48%           4                 0   100.00%          26                 0   100.00%           0                 0         -
utils/file.rs                                    224                 5    97.77%          14                 0   100.00%         144                 4    97.22%           0                 0         -
utils/formatter.rs                                55                 0   100.00%           5                 0   100.00%          39                 0   100.00%           0                 0         -
utils/logger.rs                                   71                71     0.00%           1                 1     0.00%          38                38     0.00%           0                 0         -
utils/tauri.rs                                   138                 0   100.00%          17                 0   100.00%          82                 0   100.00%           0                 0         -
workers/mod.rs                                    40                40     0.00%           2                 2     0.00%          24                24     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           5685              2361    58.47%         579               304    47.50%        4238              1816    57.15%           0                 0         -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shm11C3