src/features/hardware/hooks/useHardwareEventListener.ts:54

• The event payload type is re-declared inline here, duplicating the generated HardwareMonitorUpdate / GpuMonitorData shapes from @/rspc/bindings. This can silently drift if the backend payload changes again; prefer typing the callback as { payload: HardwareMonitorUpdate } (or importing the exact event type) to keep the listener in sync with bindings.

    (event: {
      payload: {
        cpuUsage: number;
        memoryUsage: number;
        gpus: {
          gpuId: string;
          gpuName: string;
          gpuUsage: number | null;
          gpuTemperature: number | null;
          gpuSource: string;
          gpuDedicatedMemoryUsageKb: number | null;
          gpuCoolerLevel: number | null;
        }[];
        processorsUsage: number[];
      };

src/features/hardware/hooks/useHardwareEventListener.test.ts (1)

509-532: Exercise the non-first selected-GPU path explicitly.

This only verifies the fallback/auto-select behavior: selectedGpuIdAtom is never seeded to a non-first id before reading graphicUsageHistoryAtom. A regression in the actual selected-id branch would still pass. Add one case that preselects GPU 2 and asserts the derived history follows it.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/features/hardware/hooks/useHardwareEventListener.test.ts` around lines
509 - 532, Add a test that preselects a non-first GPU id before reading
graphicUsageHistoryAtom: in useHardwareEventListener.test.ts render the hook
(calling useHardwareEventListener) and set selectedGpuIdAtom to "nvapi:1" (via
useAtom(selectedGpuIdAtom) and act) before emitting the payload with
makePayload/makeGpu, then emit the event and assert that graphicUsageHistoryAtom
(read after emit) contains the selected GPU's usage (99) instead of the fallback
first GPU; reference useHardwareEventListener, selectedGpuIdAtom,
graphicUsageHistoryAtom, renderHook, emit, makePayload, makeGpu, and Provider to
locate where to add this case.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/features/hardware/store/chart.ts (2)

11-12: ⚠️ Potential issue | 🟠 Major

Widen the GPU history atoms to nullable samples.

These histories still advertise number[], but the updater pads them with null samples. That makes graphicUsageHistoryAtom lie about its shape and hides gap values from downstream chart consumers.

Suggested fix

+export type GpuUsageHistory = Array<number | null>;
+
 /** Per-GPU usage histories keyed by gpuId */
-export const gpuUsageHistoriesAtom = atom<Record<string, number[]>>({});
+export const gpuUsageHistoriesAtom = atom<Record<string, GpuUsageHistory>>({});

 /** Resolves to the selected (or first) GPU's usage history */
-export const graphicUsageHistoryAtom = atom<number[]>((get) => {
+export const graphicUsageHistoryAtom = atom<GpuUsageHistory>((get) => {
   const selected = get(selectedGpuIdAtom);
   const histories = get(gpuUsageHistoriesAtom);
   if (selected && histories[selected]) return histories[selected];

#!/bin/bash
# Verify that history arrays are padded with nulls while the atoms are typed as number[].
rg -n -C2 'fill\(null\)|padHistory|gpuUsageHistoriesAtom|graphicUsageHistoryAtom' \
  src/features/hardware/store/chart.ts \
  src/features/hardware/hooks/useHardwareEventListener.ts

Also applies to: 53-59

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/features/hardware/store/chart.ts` around lines 11 - 12, The GPU history
atoms advertise non-nullable arrays but the updater pads histories with nulls;
update the atom types to accept nullable samples (use Record<string, (number |
null)[]> for gpuUsageHistoriesAtom and any related atoms such as
graphicUsageHistoryAtom and the atoms declared around the same block) so the
type matches runtime data, and update any exported types or selectors that
reference these atoms to the widened (number | null)[] shape.

---

37-48: ⚠️ Potential issue | 🟠 Major

Temp/fan compatibility still does not follow the selected GPU.

This store now has selected-GPU compatibility for usage, source, and memory, but gpuTempAtom/gpuFanSpeedAtom still only expose all-GPU aggregates. src/features/hardware/dashboard/components/DashboardItems.tsx:78-106 resolves those metrics against hardwareInfo.gpus[0].name, so switching GPUs can update some fields while temp/fan stay pinned to the primary adapter.

src/features/hardware/hooks/useHardwareEventListener.ts (1)

61-128: ⚠️ Potential issue | 🟠 Major

Keep missing-GPU handling consistent across all per-GPU atoms.

setGpuHistories and setGpuMemoryMap retain old keys via { ...prev }, but source/temp/fan are rebuilt from only the current payload and selectedGpuIdAtom is never revalidated. When a selected GPU drops out for one event, src/features/hardware/store/chart.ts:53-76 can return stale history/memory for that GPU while source/temp/fan silently switch to another GPU or null.

Please pick one policy and apply it everywhere: either prune missing IDs from every per-GPU atom and reselect/clear selectedGpuIdAtom, or keep last-known values consistently for every metric.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/features/hardware/hooks/useHardwareEventListener.ts` around lines 61 -
128, The per-GPU atoms are inconsistent: some preserve old keys ({ ...prev })
while others are rebuilt, causing stale data and a selected GPU mismatch. Choose
the "prune missing IDs" policy: for setGpuHistories use only current gpus (map
gpus -> padHistory([...existingHistoryForGpu? maybe use prev[gpuId] if you want
to preserve history for GPUs still present], gpu.gpuUsage)) instead of spreading
all prev keys; change setGpuMemoryMap to build from gpus only (no { ...prev });
change setGpuTempMap, setGpuSources, setGpuFanSpeedMap to continue being built
solely from current gpus; and finally revalidate selectedGpuId via
setSelectedGpuId so if the previous selected id is not in the current gpus list
you set it to gpus[0].gpuId or null. Reference symbols: setGpuHistories,
padHistory, setGpuMemoryMap, setGpuTempMap, setGpuSources, setGpuFanSpeedMap,
setSelectedGpuId, selectedGpuIdAtom.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes