Skip to content

chore: add .osv-scanner.toml to suppress false positives in OpenSSF Scorecard#1314

Merged
shm11C3 merged 1 commit into
developfrom
chore/add-osv-scanner-config
Apr 2, 2026
Merged

chore: add .osv-scanner.toml to suppress false positives in OpenSSF Scorecard#1314
shm11C3 merged 1 commit into
developfrom
chore/add-osv-scanner-config

Conversation

@shm11C3

@shm11C3 shm11C3 commented Apr 2, 2026

Copy link
Copy Markdown
Owner

Summary

Cargo.lock v4 (edition 2024) records unactivated optional dependencies, causing osv-scanner to flag crates that are never compiled (e.g. rsa via sqlx-mysql). GTK3 and other unmaintained warnings are Tauri upstream deps with no available fix.

Related Issues

Type of Change

  • Bug fix (fix/ branch)
  • New feature (feat/ branch)
  • Refactoring (refactor/ branch)
  • Documentation (docs/ branch)
  • Dependencies update
  • Other (chore/ branch)

Screenshots / Videos

Test Plan

  • Manual testing
  • Unit tests

Checklist

  • Self-reviewed the code
  • Linting and formatting pass (npm run lint && npm run format / cargo tauri-lint && cargo tauri-fmt)
  • Tests pass (npm test / cargo tauri-test)
  • No new warnings or errors

…corecard

Cargo.lock v4 (edition 2024) records unactivated optional dependencies,
causing osv-scanner to flag crates that are never compiled (e.g. rsa via
sqlx-mysql). GTK3 and other unmaintained warnings are Tauri upstream deps
with no available fix.
Copilot AI review requested due to automatic review settings April 2, 2026 21:19
@shm11C3 shm11C3 merged commit 1f52e9e into develop Apr 2, 2026
19 checks passed
@shm11C3 shm11C3 deleted the chore/add-osv-scanner-config branch April 2, 2026 21:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an OSV scanner configuration file intended to suppress known false-positive vulnerability findings (primarily around unactivated optional Rust deps in Cargo.lock v4 and upstream Tauri/Linux GTK3 transitive advisories), to reduce noise in automated security reporting.

Changes:

  • Add .osv-scanner.toml with a set of IgnoredVulns entries for specific RustSec advisory IDs.
  • Document suppression rationales inline via reason strings (optional deps / platform-specific / unmaintained upstream deps).

Comment thread .osv-scanner.toml
Comment on lines +1 to +3
[[IgnoredVulns]]
id = "RUSTSEC-2023-0071"
reason = "rsa is an optional dep of sqlx-mysql, not compiled (Cargo.lock v4 lists unactivated optional deps)"

Copilot AI Apr 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any workflow or script in this repo that runs osv-scanner (only .github/workflows/scorecard.yml runs ossf/scorecard-action). If the goal is to suppress findings in CI/Scorecard, please confirm that Scorecard consumes .osv-scanner.toml; otherwise this file may have no effect and you'd need to configure the job/tool that produces the findings to use it (or add an osv-scanner step that reads this config).

Copilot uses AI. Check for mistakes.
Comment thread .osv-scanner.toml
@@ -0,0 +1,87 @@
[[IgnoredVulns]]
id = "RUSTSEC-2023-0071"
reason = "rsa is an optional dep of sqlx-mysql, not compiled (Cargo.lock v4 lists unactivated optional deps)"

Copilot AI Apr 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ignores are global by advisory ID. That can silently mask real vulnerabilities later if the project starts compiling/using an affected crate (e.g., enabling sqlx-mysql would keep RUSTSEC-2023-0071 suppressed). Consider scoping the ignores as narrowly as the tooling allows (e.g., to specific packages/paths) and/or adding an explicit review/expiry note so the suppressions get revisited when dependencies/features change.

Suggested change
reason = "rsa is an optional dep of sqlx-mysql, not compiled (Cargo.lock v4 lists unactivated optional deps)"
reason = "rsa is an optional dep of sqlx-mysql and is not compiled in the current build (Cargo.lock v4 lists unactivated optional deps); REVIEW REQUIRED if sqlx-mysql or related features are enabled; review by 2026-01-31"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants