Remove shadcn dependency from package.json#1291
Merged
Merged
Conversation
github-actions
Bot
added
dependencies
Contributor
Coverage Report
File CoverageNo changed files found. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the shadcn CLI package from the project’s Node devDependencies to reduce dependency bloat, and updates the lockfile accordingly.
Changes:
- Removed
shadcnfrompackage.jsondevDependencies. - Updated
package-lock.jsonto reflect the dependency graph after removingshadcn(including dropping its transitive packages).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Drops shadcn from devDependencies. |
| package-lock.json | Lockfile re-resolve reflecting removal of shadcn and its transitive deps. |
Comment on lines
38
to
42
| "jsdom": "^29.0.1", | ||
| "license-checker": "^25.0.1", | ||
| "rollup-plugin-visualizer": "^7.0.0", | ||
| "shadcn": "^4.0.0", | ||
| "tailwindcss": "^4.1.17", | ||
| "typescript": "^6.0.2", |
There was a problem hiding this comment.
shadcn (the CLI) is being removed from devDependencies, but the repo still contains components.json with a shadcn/ui schema and UI files that mention they were generated by shadcn/ui. If we still expect contributors to scaffold/update components via the CLI, consider either keeping shadcn as a devDependency or updating docs/workflows to use npx shadcn@<version> and clarifying that it’s not installed locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removing the shadcn dependency from package.json simplifies the project's dependencies and reduces potential bloat.
Related Issues
Type of Change
fix/branch)feat/branch)refactor/branch)docs/branch)chore/branch)Screenshots / Videos
Test Plan
Checklist
npm run lint && npm run format/cargo tauri-lint && cargo tauri-fmt)npm test/cargo tauri-test)