Ci/fix/#1272 2#1274
Merged
Merged
Conversation
github-actions
Bot
added
the
github_actions
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the perf-test GitHub Actions workflow to fix macOS perf runs by building a macOS app bundle and pointing perf-monitor at the bundled executable, plus improved visibility into perf results artifacts.
Changes:
- Add a dedicated macOS Tauri build step that produces an
.appbundle. - Update macOS perf-monitor invocation to use the executable inside the
.appbundle. - Add an
always()step to printperf-results.jsonwhen available.
| > perf-results.json | ||
|
|
||
| - name: Show results | ||
| if: always() |
There was a problem hiding this comment.
The cat ... 2>/dev/null || ... command is shell-specific and will fail on Windows runners because run defaults to pwsh on Windows. To make this step reliable across OSes, either set an explicit shell (e.g., shell: bash) or rewrite the command in pwsh (which is available on all GitHub-hosted runners) using Test-Path/Get-Content.
Suggested change
| if: always() | |
| if: always() | |
| shell: bash |
Comment on lines
+49
to
+58
| - name: Build Tauri app (macOS) | ||
| if: runner.os == 'macOS' | ||
| uses: tauri-apps/tauri-action@73fb865345c54760d875b94642314f8c0c894afa # v0.6.1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| args: --bundles app -- --profile ci | ||
|
|
||
| - name: Build Tauri app | ||
| if: runner.os != 'macOS' |
There was a problem hiding this comment.
This introduces two near-identical steps that only differ by if: and args. Consider collapsing into a single tauri-action step and making args conditional via expressions (or moving OS-specific logic into env/variables) to reduce duplication and the chance of the macOS/non-macOS paths drifting over time.
Contributor
Coverage Report
File CoverageNo changed files found. |
Contributor
Rust Backend Coverage ReportCoverage Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
Type of Change
fix/branch)feat/branch)refactor/branch)docs/branch)chore/branch)Screenshots / Videos
Test Plan
Checklist
npm run lint && npm run format/cargo tauri-lint && cargo tauri-fmt)npm test/cargo tauri-test)