Skip to content

add russian locale#1215

Merged
shm11C3 merged 7 commits into
shm11C3:developfrom
Denis11212:develop
Mar 6, 2026
Merged

add russian locale#1215
shm11C3 merged 7 commits into
shm11C3:developfrom
Denis11212:develop

Conversation

@Denis11212

@Denis11212 Denis11212 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

shm11C3
shm11C3 requested changes Mar 4, 2026
View reviewed changes

@shm11C3 shm11C3 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Denis11212
Hi! Thanks a lot for your first PR 🙌
This improvement is really appreciated.

I left a few review comments—could you please address them when you have a moment?
Once the following points are handled, we should be good to merge:

If anything is unclear, feel free to ask in this thread—I’m happy to help or provide an example.
I’ll take another look after the updates. Thanks again!

Comment thread src/lang/en.json
Comment thread src/lang/ja.json Outdated
Comment thread src/lang/ru.json
@Denis11212

Denis11212 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

@shm11C3 check it for now. I don't have the ability to compile the program. Send me some screenshots and tomorrow, if I have the opportunity, I'll correct the words.

@shm11C3

shm11C3 commented Mar 4, 2026

Copy link
Copy Markdown
Owner

@Denis11212 Sure — here are the screenshots you asked for.
image
image
image
image
image
image
image

As a separate required step for this PR, please fix the build-breaking JSON issue in src/lang/en.json (missing comma). You don’t need to compile locally for that.

For translation wording/polish, we can iterate after merge via an Issue/Discussion if needed — it doesn’t have to be perfect in this PR.

@shm11C3

shm11C3 commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Note: If you’d like to compile and test the app locally, you’ll also need to fix the following files.
This is optional and not required for this PR.

HardwareVisualizer/src/lib/i18n.ts

Lines 6 to 13 in 8a61b4d

const resources = {
en: {
translation: en,
},
ja: {
translation: ja,
},
};

HardwareVisualizer/src/types/i18next.d.ts

Lines 1 to 8 in 8a61b4d

import "i18next";
import type en from "@/lang/en.json";
import type ja from "@/lang/ja.json";
type Resources = {
en: typeof en;
ja: typeof ja;
};

HardwareVisualizer/src-tauri/src/services/language_service.rs

Line 4 in 8a61b4d

pub const SUPPORTED_LANGUAGES: [&str; 2] = ["en", "ja"];

@Denis11212

Denis11212 commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

@shm11C3 Looks good. Something has probably been corrected. It's especially nice to use the icon instead of the word inside the circle. Once you release the new version, I'll check and correct the translation. Since I use your program.

@shm11C3 shm11C3 self-requested a review March 6, 2026 13:06
shm11C3
shm11C3 approved these changes Mar 6, 2026
View reviewed changes

@shm11C3 shm11C3 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Denis11212
Thanks for the contribution! The translation files look good, so I’m approving this as a locale data contribution.

I’ll handle the remaining app-side wiring separately, such as registering ru in the i18n setup / types / supported languages.

@shm11C3 shm11C3 merged commit ae18f68 into shm11C3:develop Mar 6, 2026
17 checks passed
github-actions Bot pushed a commit that referenced this pull request Mar 6, 2026
@github-actions
docs: document Russian language support in features table
7213945 
Add Language Support row to the Features table in both README.md and
docs/README.ja.md to reflect the Russian locale added in #1222 and #1215.
@github-actions github-actions Bot mentioned this pull request Mar 6, 2026
Merged
shm11C3 pushed a commit that referenced this pull request Mar 7, 2026
@github-actions
docs: document Russian language support in features table (#1224)
4819ad7 
Add Language Support row to the Features table in both README.md and
docs/README.ja.md to reflect the Russian locale added in #1222 and #1215.

Co-authored-by: docs-bot <docs-bot@github-actions>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shm11C3 shm11C3 shm11C3 approved these changes

Assignees

No one assigned

Labels

frontend i18n

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Denis11212 @shm11C3