Fix: update tauri-updater script to use node for JSON parsing and replace ripgrep with grep#1105
Merged
Conversation
…lace ripgrep with grep
Contributor
Coverage Report
File CoverageNo changed files found. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Tauri dependency update script used in CI/automation to be more portable and to keep both Cargo.toml and Cargo.lock in sync when bumping Tauri-related crates.
Changes:
- Include
tauri-spectain thecargo upgradeflow. - Replace
grep -Pusage withgrep -Efor broader compatibility. - Consolidate
cargo updatecalls into a single invocation that updates Tauri + all detectedtauri-plugin-*crates inCargo.lock.
| done | ||
| cargo update "${TAURI_UPDATE_ARGS[@]}" || true | ||
|
|
||
| # Update lock file |
There was a problem hiding this comment.
The new "Update lockfile entries" comment suggests Cargo.lock is handled here, but the later "# Update lock file" comment (below this hunk) is now redundant/misleading since cargo update already updates Cargo.lock. Consider removing or rewording the later comment so the script’s steps stay clear.
Suggested change
| # Update lock file | |
| # Return to repo root |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.