Skip to content

Chore/updater-devmode#1080

Merged
shm11C3 merged 2 commits into
developfrom
chore/updater-devmode
Feb 8, 2026
Merged

Chore/updater-devmode#1080
shm11C3 merged 2 commits into
developfrom
chore/updater-devmode

Conversation

@shm11C3

@shm11C3 shm11C3 commented Feb 8, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings February 8, 2026 10:29
@github-actions github-actions Bot added the rust Pull requests that update Rust code label Feb 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce updater-related noise during development builds of the Tauri app.

Changes:

  • Skip the updater check entirely in Rust when compiled with debug_assertions.
  • Change the committed Tauri app version in tauri.conf.json to 0.0.0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src-tauri/tauri.conf.json Changes the app’s configured version to 0.0.0 (intended for dev-mode behavior).
src-tauri/src/commands/updater.rs Adds a debug-build early return to avoid performing updater checks during development.

Comment thread src-tauri/tauri.conf.json
"productName": "HardwareVisualizer",
"mainBinaryName": "hardware-visualizer",
"version": "1.5.0",
"version": "0.0.0",

Copilot AI Feb 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the Tauri app version to 0.0.0 is likely to break the repo’s release/versioning workflows and produce incorrect app version metadata in non-tagged builds. The repo has a PR-time version check workflow that reads src-tauri/tauri.conf.json (.github/workflows/check-version.yml), and release builds patch this field via .github/scripts/update-tauri-config.ts; keeping 0.0.0 in the committed config will make that check fail and can also confuse update/version comparisons. Prefer keeping the real next version in tauri.conf.json (and relying on the new debug-only updater skip), or gate a dev-only version override via build tooling rather than committing 0.0.0.

Copilot uses AI. Check for mistakes.
@shm11C3 shm11C3 merged commit d824fad into develop Feb 8, 2026
29 checks passed
@shm11C3 shm11C3 deleted the chore/updater-devmode branch February 8, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants