Fix(macos) archive DB initialization and data directory creation#1050
Merged
Conversation
github-actions
Bot
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Updates macOS app data path resolution and ensures the SQLite archive database directory exists before connecting, consolidating archive DB access through a shared pool helper.
Changes:
- Add macOS-specific app data directory resolution (
~/Library/Application Support/<identifier>), keeping Linux on~/.config/<identifier>. - Ensure the database parent directory is created before SQLite connects.
- Remove per-module DB pool creation in archive modules and reuse
database::db::get_pool().
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src-tauri/src/utils/file.rs |
Splits macOS vs Linux app data directory logic and extends tests for macOS paths. |
src-tauri/src/infrastructure/database/db.rs |
Creates the DB parent directory before establishing the SQLx SQLite pool. |
src-tauri/src/infrastructure/database/hardware_archive.rs |
Uses shared db::get_pool() instead of a local pool initializer. |
src-tauri/src/infrastructure/database/gpu_archive.rs |
Uses shared db::get_pool() instead of a local pool initializer. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.