Chore: Remove rust_decimal dependency and simplify rounding function#1047
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the rust_decimal dependency and replaces it with a simpler native floating-point implementation for the rounding function. The change reduces dependencies and simplifies the codebase while maintaining the core functionality.
Changes:
- Removed
rust_decimaldependency fromCargo.toml - Simplified the
roundfunction to use native floating-point arithmetic instead of the Decimal type - Cleaned up transitive dependencies in
Cargo.lock(ahash, arrayvec, bitvec, borsh, bytecheck, funty, ptr_meta, radium, rend, rkyv, seahash, simdutf8, tap, wyz)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src-tauri/src/utils/formatter.rs | Removed rust_decimal imports and simplified round function to use native f64 arithmetic |
| src-tauri/Cargo.toml | Removed rust_decimal dependency |
| src-tauri/Cargo.lock | Cleaned up rust_decimal and its transitive dependencies |
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.