Rollback PSR installation causing massive workflow failures#3
Rollback PSR installation causing massive workflow failures#3shivammathur merged 1 commit intoshivammathur:mainfrom emmadesilva:main
Conversation
This reverts commit 83d1155.
emmadesilva
changed the title
emmadesilva
changed the title
|
merge it! |
See shivammathur/setup-php#799 (comment) Can be reverted after shivammathur/php-ubuntu#3 is merged
See shivammathur/setup-php#799 (comment) Can be reverted after shivammathur/php-ubuntu#3 is merged
|
tagging @shivammathur for visibility |
|
Such changes should only be done in majors IMO. Thanks for the quick revert |
Agreed. I don't think this change was intentional at all, which is why I think it needs to be rolled back ASAP so that it can be properly rereleased in a major update. Hoping it can get merged soon. Considering how much the Setup PHP action is used and the massive impact it has, I really wish more companies would sponsor the maintainer so more resources could be put into making sure things like this doesn't happen. To be clear, I fully appreciate the work Shivam is doing and acknowledge that we as users of free software don't have the rights to make demands, with that said, the system is pretty broken. In an ideal world the companies that rely on tools like these would sponsor the maintainer so they either could work full time, or pay more developers to be on board. Considering the cost I imagine a faulty change like this could have on production systems it seems like a few dollars a month would be quite little for the companies, but it would quickly add up to something that could make a large difference for the maintainer. Rant over! |
Until shivammathur/php-ubuntu#3 is merged Signed-off-by: Nathanael Esayeas <[email protected]>
|
@caendesilva Apologies for this, The change was a bug fix for shivammathur/setup-php#796, but I guess I created a bigger issue.
|
11 participants
This reverts commit 83d1155 "Revert 'Add psr for PHP 7.0 and above'" as it breaks installations. This rollback will fix shivammathur/setup-php#798 and shivammathur/setup-php#799