Use browserify for building and add some tests#175
Use browserify for building and add some tests#175kt3k wants to merge 2 commits intoshipshapecode:masterfrom
Conversation
b52ca0c to
b78f778
Compare
81df60e to
a755a87
Compare
|
@TrevorBurnham there's anything we could do to unblock this one? Without it, we are prevented to use Thanks |
|
Hi, |
|
This should absolutely be merged @HubSpot @TrevorBurnham. |
|
I have forked the branch by @kt3k and included a new build on it. As a temporary solution you can refer to Tether 1.3.4 browserified build like this in your {
"dependencies": {
"tether": "balloob/tether#7e0d48e4ac2162e251dc2b69d7c13e6c29a5667f"
}
} |
|
close this in favor of #359 |
|
Yes this should be reopened and merged, fork is being used by reactstrap to work around this but would be best to correct here |
|
Oops, thanks for pointing it. By the way, now I think rollup is better choice for bundling this project because it produces much simpler and smaller bundle than browserify. |
|
I'm trying to use 'reactstrap' and the issue caused by 'reactstrap-tether' brought me here. It seems this PR will create a UMD which cannot be consumed by 'browserify'. {
"dependencies": {
"reactstrap-tether": "^1.3.4",
"browserify": "^13.0.0"
},
"name": "bad-require",
"private": true,
"scripts": {
"start": "browserify -d -e test.js",
},
}The test.js is one line: var tether = require('reactstrap-tether');Run will generate errors saying The webpack might work with this properly. But why break browserify (or did i miss anything) ? |
|
bump |
|
Thanks @awerlang! I think I'll try to fix it here first because the change is needed for |
|
Closing for inactivity. |
What I did in this PR:
standalone: 'Tether'option in browserify settings makes the bundleumd.dist/js/tether(.min).jsmust work as an umd module.