Distinguish backing store access from hook call in property hooks#311
Merged
Distinguish backing store access from hook call in property hooks#311
Conversation
This produces: > Property PropertyHooks13\MemoizedProperty::$id is never written But it's not true. It's written, on read.
Self-referencing property access inside a hook accesses the backing store directly without calling the corresponding hook. Previously such usages were skipped entirely, which caused false positives for memoizing patterns like `$this->id ??= ...`. Now these usages are recorded with a non-propagating flag: the property is marked as used, but the graph walk does not continue into the hook body. This correctly models the difference between accessing the property (backing store) and calling a hook.
abeb0f0 to
4e2b50c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #308