Failing test case for bug with memoizing property hook that is read is reported as not written#308
Closed
ruudk wants to merge 1 commit intoshipmonk-rnd:masterfrom
Closed
Failing test case for bug with memoizing property hook that is read is reported as not written#308ruudk wants to merge 1 commit intoshipmonk-rnd:masterfrom
ruudk wants to merge 1 commit intoshipmonk-rnd:masterfrom
Conversation
This produces: > Property PropertyHooks13\MemoizedProperty::$id is never written But it's not true. It's written, on read.
Member
|
This is caused by this condition, which is there to avoid transitivity trigger towards set hook (because self-referencing property access is NOT calling such property hook). But this is wrong for your case, so I need to figure out how to distinguish those two. Currently a property-write always means "set hook called". |
Member
Contributor
Author
|
Thank you!! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This produces:
But it's not true. It's written, on read.
See failing test.