Skip to content

feat: add dynamic node_module resolution for wasm path#412

Closed
muenzpraeger wants to merge 4 commits intoshikijs:mainfrom
muenzpraeger:rw/require-resolve-to-import
Closed

feat: add dynamic node_module resolution for wasm path#412
muenzpraeger wants to merge 4 commits intoshikijs:mainfrom
muenzpraeger:rw/require-resolve-to-import

Conversation

@muenzpraeger
Copy link
Copy Markdown
Collaborator

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 13, 2023

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 928814b
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/63c14a37cd889d0008db0ddc
😎 Deploy Preview https://deploy-preview-412--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Nedilko
Copy link
Copy Markdown

Nedilko commented Jan 16, 2023

really waiting you to fix this

@selenecodes
Copy link
Copy Markdown

Same, my react server-side components can't use rehype-pretty-code due to this issue.

@Nedilko
Copy link
Copy Markdown

Nedilko commented Jan 16, 2023

Same, my react server-side components can't use rehype-pretty-code due to this issue.

as a temporary fix I apply this

@Nedilko
Copy link
Copy Markdown

Nedilko commented Jan 16, 2023

thanks to @pengx17

@wooorm
Copy link
Copy Markdown
Contributor

wooorm commented Jan 16, 2023

Looks a bit frail to me, perhaps something like import-meta-resolve (but then I’m the author of that)?

@octref
Copy link
Copy Markdown
Collaborator

octref commented Jan 27, 2023

import-meta-resolve looks good. If all you want is shiki to work with next 13, you can see this sample: https://github.com/shikijs/next-shiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't load shiki vscode-oniguruma in Next 13 react server component

5 participants