Merged
Conversation
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was referenced Dec 20, 2022
orta
reviewed
Dec 23, 2022
| // It is recommended to use a Response object. Oniguruma will then use WebAssembly.instantiateStreaming(), which | ||
| // means it can start parsing the file while it's still downloading. | ||
| const wasmResponse = new Response(await fetch('/your/path/onig.wasm')) | ||
| const wasmResponse = await fetch('/your/path/onig.wasm') |
Contributor
There was a problem hiding this comment.
Wouldn't this await force the full load ahead of time, instead of streaming like the comment? (both old and new may be wrong here?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor docs update