Skip to content

Commit 92a8589

Browse files
committed
fix(policy): reconcile raw OPA validation with current main
Integrate the current MCP protocol profiles while preserving raw policy validation, filesystem defaults, and redacted startup evaluation errors. Accept upstream's architecture directory removal and retain the loader documentation in the published policy schema reference. Refs NVIDIA#3092. Signed-off-by: Shiju <[email protected]>
2 parents 76dcfcc + c0eb3db commit 92a8589

139 files changed

Lines changed: 11216 additions & 7443 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.agents/skills/build-openshell-mxc-windows/SKILL.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ The Windows build lane is implemented by these tracked files:
3131
| `tasks/rust.toml`, `tasks/test.toml`, and `tasks/markdown.toml` | Windows routing for compiler-bearing checks, explicit Unix-only test skips, and Markdown dependency setup. |
3232
| `tasks/scripts/windows-msvc.ps1` | PowerShell wrapper that enters the Visual Studio developer environment and invokes Cargo. |
3333
| `.github/workflows/windows-msvc.yml` | Opt-in PR lint and test plus advisory `windows` branch cache seeding and dependent binary builds on native x64 and ARM64 runners. |
34-
| `architecture/windows-msvc-build.md` | Design notes and validation contract. |
3534
| `.agents/skills/build-openshell-mxc-windows/` | This skill and companion reference material. |
3635

3736
Use the code that is already in the repo. Do not generate a parallel Windows

‎.agents/skills/build-openshell-mxc-windows/reference.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ maintaining the existing build-only Windows MSVC lane.
1010
| `tasks/windows.toml` | Mise task definitions for `windows:*`. |
1111
| `tasks/scripts/windows-msvc.ps1` | Visual Studio environment discovery, rustup target setup, Cargo invocation, logs, artifact report. |
1212
| `.github/workflows/windows-msvc.yml` | Opt-in PR lint and test plus `windows` branch cache seeding and dependent binary builds on native x64 and ARM64 runners. |
13-
| `architecture/windows-msvc-build.md` | Human-readable design contract. |
1413

1514
## Commands
1615

‎.agents/skills/create-rfc/SKILL.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ Keep the template as the source of truth for section guidance.
3333
## Writing Standards
3434

3535
- Prefer concrete design statements over placeholder language.
36-
- Link to relevant issues, prior RFCs, and architecture docs when they provide
36+
- Link to relevant issues, prior RFCs, and published docs when they provide
3737
needed context.
3838
- Keep rejected or left-out designs in Alternatives, not Proposal.
3939
- Use Mermaid diagrams for architecture or data flow when a diagram would make
4040
the proposal easier to review.
41-
- Do not update `architecture/` or published docs just because an RFC was
41+
- Do not update published docs just because an RFC was
4242
drafted. Those updates belong with implementation or with an accepted RFC when
4343
the user asks for them.
4444

‎.agents/skills/create-spike/SKILL.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ The prompt to the reviewer **must** instruct it to:
9191

9292
8. **Look at relevant tests to understand test coverage expectations.** What test patterns exist? What level of coverage is expected for this area?
9393

94-
9. **Check architecture docs** in the `architecture/` directory for relevant documentation about the affected subsystems.
94+
9. **Check design records** in `rfc/` and the affected crate `README.md` files for relevant decisions and constraints.
9595

9696
10. **Assess gateway config documentation impact.** If the change would add, remove, rename, or change defaults for gateway TOML keys or driver-specific config options, call out that `docs/how-it-works/gateways/configuration.mdx` must be updated. If the change is surfaced through Helm or compute-driver setup docs, call out the relevant deployment or compute-driver docs too.
9797

@@ -156,7 +156,7 @@ gh issue create \
156156
157157
### Architecture Overview
158158
159-
<How the affected subsystems work today. Include data flow, component interactions, and relevant design decisions. Reference architecture docs if applicable.>
159+
<How the affected subsystems work today. Include data flow, component interactions, and relevant design decisions. Reference RFCs or crate READMEs if applicable.>
160160
161161
### Code References
162162
@@ -278,7 +278,7 @@ User says: "Allow sandbox egress to private IP space via networking policy"
278278
- Reads OPA policy evaluation pipeline in `opa.rs` and `crates/openshell-sandbox/data/sandbox-policy.rego`
279279
- Reads proto definitions in `sandbox.proto` for `NetworkEndpoint`
280280
- Maps the 4-layer defense model: netns, seccomp, OPA, SSRF check
281-
- Reads `architecture/security-policy.md` and `architecture/sandbox.md`
281+
- Reads RFC 0002 and the `openshell-policy` crate README
282282
- Identifies exact insertion points: policy field addition, SSRF check bypass path, OPA rule extension
283283
- Assesses: Medium complexity, High confidence, ~6 files
284284
3. Fetch labels — select `area:sandbox`, `area:proxy`, `area:policy`, `state:validated`

‎.agents/skills/sync-agent-infra/SKILL.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@ For each file in the table above, check for the following inconsistencies:
150150
3. **Unique names** — Parse the `name` field from every `SKILL.md` under both roots. Every name must be globally unique and match the documented inventory.
151151
4. **Local references** — Every relative Markdown link and referenced file in a skill must resolve within that installed skill directory unless the reference is an explicit published URL.
152152
5. **Canonical paths** — Contributor skills that name the source location of a public skill must use `skills/<name>/...`, never `.agents/skills/<name>/...`.
153-
6. **Public portability** — Public skills must not require repository-relative files under `docs/`, `architecture/`, `crates/`, `deploy/`, or `.agents/`; source builds; `mise`; or repository E2E workflows. Use installed `openshell --help` for command syntax and Markdown endpoints under `https://docs.nvidia.com/openshell/latest/` (URLs ending in `.md`) for product documentation.
154-
7. **No canonical documentation copies** — Review public reference files and large command/schema blocks. Remove material that merely copies CLI help, policy schemas, architecture docs, or published operational documentation; retain only skill-specific reasoning and worked interactions.
153+
6. **Public portability** — Public skills must not require repository-relative files under `docs/`, `crates/`, `deploy/`, or `.agents/`; source builds; `mise`; or repository E2E workflows. Use installed `openshell --help` for command syntax and Markdown endpoints under `https://docs.nvidia.com/openshell/latest/` (URLs ending in `.md`) for product documentation.
154+
7. **No canonical documentation copies** — Review public reference files and large command/schema blocks. Remove material that merely copies CLI help, policy schemas, RFCs, or published operational documentation; retain only skill-specific reasoning and worked interactions.
155155
8. **Discovery** — Run `npx -y skills add . --list` from a clean checkout or disposable copy. It must list exactly the four public skills. Remove any generated lock file or installed directory after the check.
156156

157157
## Step 3: Report Drift

‎.agents/skills/tui-development/SKILL.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ match app.screen {
102102
}
103103
```
104104

105-
Within the `Sandbox` screen, the top 20% renders sandbox metadata (`sandbox_detail`), and the bottom 80% dispatches based on focus and tab state:
105+
Within the `Sandbox` screen, `sandbox_detail::required_height` sizes the metadata and restart status pane to its contents. The remaining area dispatches based on focus and tab state:
106106

107107
```rust
108108
match app.focus {
@@ -262,7 +262,7 @@ The `Theme` struct has 16 `Style` fields, accessed at runtime via `app.theme`:
262262
| `border` | EVERGLADE fg | Light sage fg | Unfocused panel borders |
263263
| `border_focused` | NVIDIA_GREEN fg | NVIDIA_GREEN_DARK fg | Focused panel borders |
264264
| `status_ok` | NVIDIA_GREEN fg | NVIDIA_GREEN_DARK fg | Healthy, INFO, Ready |
265-
| `status_warn` | Yellow fg | Dark yellow fg | Degraded, WARN, Provisioning |
265+
| `status_warn` | Yellow fg | Dark yellow fg | Degraded, WARN, Provisioning, Starting |
266266
| `status_err` | Red fg | Dark red fg | Unhealthy, ERROR |
267267
| `key_hint` | NVIDIA_GREEN fg | NVIDIA_GREEN_DARK fg | Keyboard shortcut labels |
268268
| `log_cursor` | EVERGLADE bg | Light green bg | Selected log line highlight |
@@ -297,7 +297,7 @@ fn draw_detail_popup(frame: &mut Frame<'_>, data: &MyData, area: Rect, theme: &T
297297

298298
- **Selected row**: Green `▌` left-border marker on the selected row. Active gateway also gets a green `●` dot.
299299
- **Focused panel**: Border changes from `border` to `border_focused` style.
300-
- **Status indicators**: Green for healthy/ready/info, yellow for degraded/provisioning/warn, red for unhealthy/error.
300+
- **Status indicators**: Green for healthy/ready/info, yellow for degraded/provisioning/starting/warn, red for unhealthy/error.
301301
- **Separators**: Muted `│` characters between title bar segments and nav bar sections.
302302
- **Log source labels**: `"sandbox"` source renders in `accent` (green), `"gateway"` in `muted`.
303303

@@ -423,7 +423,7 @@ All actions are accessible via keyboard shortcuts displayed in the nav bar. The
423423
| `crates/openshell-tui/src/ui/providers.rs` | Provider list table with profile-aware columns: Name, Category, Type, Credentials, Workspace |
424424
| `crates/openshell-tui/src/ui/global_settings.rs` | Global settings table: Key, Type, Value. Includes edit overlay, confirm-set, and confirm-delete popups |
425425
| `crates/openshell-tui/src/ui/sandboxes.rs` | Reusable sandbox table widget with columns: Name, Status, Created, Age, Image, Workspace, Notes |
426-
| `crates/openshell-tui/src/ui/sandbox_detail.rs` | Sandbox metadata view — name, status, image, created, age, providers, policy version |
426+
| `crates/openshell-tui/src/ui/sandbox_detail.rs` | Sandbox metadata view — name, status, image, created, age, restart policy/status, providers, policy version |
427427
| `crates/openshell-tui/src/ui/sandbox_policy.rs` | Policy viewer — rendered policy lines with scroll support, tab title |
428428
| `crates/openshell-tui/src/ui/sandbox_settings.rs` | Sandbox settings table: Key, Type, Value, Scope. Includes edit overlay and confirm popups |
429429
| `crates/openshell-tui/src/ui/sandbox_logs.rs` | Structured log viewer — timestamp, source, level, target, message, key=value fields, scroll position, source filter, visual selection mode, clipboard copy |

0 commit comments

Comments
 (0)