Skip to content

Conversation

@AntoniMarcinek
Copy link
Contributor

Sorry for a large diff, but I couldn't find a logical way to slice it into smaller change sets

@AntoniMarcinek AntoniMarcinek changed the title contribution to #87 contribution to issue #87 Nov 11, 2020
@AntoniMarcinek AntoniMarcinek changed the title contribution to issue #87 contribution to issue #87 improve documentation Nov 11, 2020
@ko1nksm
Copy link
Member

ko1nksm commented Nov 12, 2020

Wow great, thanks! I will check and merge later.

@AntoniMarcinek
Copy link
Contributor Author

@ko1nksm Could you also have a look at #121 ?

@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #120 (19efbd6) into master (ae5d903) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files          98       98           
  Lines        4268     4268           
=======================================
  Hits         2826     2826           
  Misses       1442     1442           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae5d903...cc60701. Read the comment docs.

@ko1nksm ko1nksm merged commit 8472d3a into shellspec:master Nov 14, 2020
@ko1nksm
Copy link
Member

ko1nksm commented Nov 14, 2020

Merged, thanks!

ko1nksm added a commit that referenced this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants