Test case for #92#93
Merged
shellscape merged 1 commit intoshellscape:masterfrom Oct 9, 2017
Merged
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So test case for #92
Please check one:
This PR:
Globals
At first i thought RegExp from globals.js needed fixin:, I was wrong it matches
@var:and@var :.So I tried with parsing
Tokenize at rule
Running tests (new one included), I pin pointed tokenize-at-rule.js#L36.
When declaration contains a space between variable name and
:,It makes
state.cssPartone character to shorter to enter word definition bloc.Is it the way to go or am I doing it wrong?
Regards