fix: proposed token important fix #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 96.09% 96.36% +0.26%
==========================================
Files 8 8
Lines 205 220 +15
==========================================
+ Hits 197 212 +15
Misses 8 8
Continue to review full report at Codecov.
|
jwilsson
requested changes
Nov 14, 2018
Owner
Author
|
@jwilsson updated those two tests |
jwilsson
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue # if any, does this resolve?
#118
Please check one:
This PR:
From #124
This PR supersedes #124. It uses a different approach which alters the tokenizer when
importantidentifiers are split between multiple tokens.