Handle spaces between variable name and colon#100
Closed
davidyorr wants to merge 1 commit intoshellscape:masterfrom
Closed
Handle spaces between variable name and colon#100davidyorr wants to merge 1 commit intoshellscape:masterfrom
davidyorr wants to merge 1 commit intoshellscape:masterfrom
Conversation
Owner
|
@davidyorr any chance there's a spec that references |
Contributor
Author
|
I saw and the rest of the at-rules I looked through were https://developer.mozilla.org/en-US/docs/Web/CSS/At-rule the w3 spec also has a few examples https://www.w3.org/TR/css3-page/#page-selectors |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92
Please check one:
This PR:
The previous solution I had wasnt checking that the at-word was directly next to the " :". So in the wikimedia file the
:last-childwas passing the condition for the@importstatement even though theyre not next to each other.I added another line that checks that the at-word and " :" have nothing else between them. And I believe that
@pageis the only at-rule that can have a colon directly after it.