Skip to content

Handle spaces between variable name and colon#100

Closed
davidyorr wants to merge 1 commit intoshellscape:masterfrom
davidyorr:master
Closed

Handle spaces between variable name and colon#100
davidyorr wants to merge 1 commit intoshellscape:masterfrom
davidyorr:master

Conversation

@davidyorr
Copy link
Copy Markdown
Contributor

Fixes #92

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

The previous solution I had wasnt checking that the at-word was directly next to the " :". So in the wikimedia file the :last-child was passing the condition for the @import statement even though theyre not next to each other.

@import 'mediawiki.mixins';

li {
  &:not( :last-child ) {
    margin-bottom: 16px;
  }
}

I added another line that checks that the at-word and " :" have nothing else between them. And I believe that @page is the only at-rule that can have a colon directly after it.

@shellscape
Copy link
Copy Markdown
Owner

@davidyorr any chance there's a spec that references @page that we can point to? (spec links are particularly useful when we get bug reports about added features and/or updated parsing)

@davidyorr
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants