feat(charlie): align next/v3 CLI --use-preview-props behavior with main#358
Conversation
|
This pull request contains too many files for a standard review. Please consider reducing the number of changed files or splitting the PR into smaller, more manageable parts for review. |
|
@CharlieHelps you were supposed to base off of next/v3. that should be the branch target. |
|
Acknowledging the branch feedback on PR #358 and adjusting my mental context to target
|
Expand this to see my work.
|
|
Good catch — I had the PR targeting I’ve updated PR #358 so its base branch is now |
Resolves #352
Subtask of #348.
This PR aligns the
next/v3CLI’s--use-preview-propsbehavior, help text, and tests withmainwhile keepingemail checkbased on caniemail.Summary of changes
CLI flags (next/v3)
email buildandemail checkto accept the--use-preview-propsflag in the same way as onmain.Build / check pipeline wiring
usePreviewPropsthrough thebuildTemplates(and related) helpers used byemail buildso builds honorpreviewPropswhen the flag is set.email checkpipeline to passusePreviewPropsto template building/checking so the samepreviewPropsused for builds/previews are also used for checks.email checkusing caniemail for compatibility checks (did not change it to use@jsx-email/doiuse-email).CLI help and docs
email buildandemail checkhelp output onnext/v3withmainby:--use-preview-propsas a first-class flag for both commands.email checkruns caniemail-based checks while still honoringpreviewPropswhen requested.--use-preview-propsdiscoverable and described consistently across branches.Tests
email buildonnext/v3to verify that:--use-preview-propsis accepted and correctly wired into the build pipeline.previewPropswhen the flag is enabled.email checkonnext/v3that:--use-preview-propsis accepted and forwarded into the checking pipeline.previewPropsas builds/previews.mainfor parity.Notes
next/v3, notmain.email checkis preserved per the follow-up comments on charlie: head vs next/v3 #348; this PR only aligns how--use-preview-propsis exposed, documented, and exercised in tests.