Cleanup LICENSE#966
Merged
nfischer merged 1 commit intoshelljs:masterfrom Oct 26, 2020
reviewher:patch-1
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 34 34
Lines 1298 1298
=======================================
Hits 1261 1261
Misses 37 37 ☔ View full report in Codecov by Sentry. |
Member
|
The example you linked to is a markdown license; could you also link to a plain text license? Just want to double check since licenses are kind of a sensitive thing. |
Contributor
Author
|
Better example: https://github.com/highlightjs/highlight.js/blob/master/LICENSE (same body text and formatting) |
nfischer
approved these changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github does not currently recognize the license of this project. It says "View License" at the top. Other BSD-3-Clause projects like freeCodeCamp clearly say BSD-3-Clause in the top bar.
It seems that Github is very finicky and expects the exact formatting as well as body text. The license was reshaped to match the formatting of other projects, so with this change GH will finally recognize that shelljs is BSD-3-clause