sed with -i option now runs silently #959
Merged
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #959 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 34 34
Lines 1289 1291 +2
=======================================
+ Hits 1254 1256 +2
Misses 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nfischer
approved these changes
Aug 13, 2019
…o sed-i-quiet Updated gpg key to verify the commit
|
Hi all, is there anything preventing this PR from merging? |
|
I need that too :/ could you please merge this? |
nfischer
added
bash compat
|
Any plans on when the next release might be? Would be great to get this into |
nfischer
added a commit
to shelljs/shx
that referenced
this pull request
Mar 9, 2025
This updates the ShellJS peer dependency to the latest release. This also drops support for all node versions prior to v18 to match ShellJS's version range. This includes some changes due to the latest shelljs version: * `shx sed -i` will now run silently. This is compatible with unix behavior. See shelljs/shelljs#959 * `shx --version` no longer prints the ShellJS version. This is a consequence of the switch to an explicit "exports" list in shelljs (see shelljs/shelljs#1195 and shelljs/shelljs#1135). Test: npm test
nfischer
added a commit
to shelljs/shx
that referenced
this pull request
Mar 9, 2025
This updates the ShellJS peer dependency to the latest release. This also drops support for all node versions prior to v18 to match ShellJS's version range. This includes some changes due to the latest shelljs version: * `shx sed -i` will now run silently. This is compatible with unix behavior. See shelljs/shelljs#959 * `shx --version` no longer prints the ShellJS version. This is a consequence of the switch to an explicit "exports" list in shelljs (see shelljs/shelljs#1195 and shelljs/shelljs#1135). Test: npm test
nfischer
added a commit
to shelljs/shx
that referenced
this pull request
Mar 9, 2025
This updates the ShellJS peer dependency to the latest release. This also drops support for all node versions prior to v18 to match ShellJS's version range. This includes some changes due to the latest shelljs version: * `shx sed -i` will now run silently. This is compatible with unix behavior. See shelljs/shelljs#959 * `shx --version` no longer prints the ShellJS version. This is a consequence of the switch to an explicit "exports" list in shelljs (see shelljs/shelljs#1195 and shelljs/shelljs#1135). Test: npm test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #159 with shx