Skip to content

docs(exec): document security concerns#950

Merged
nfischer merged 1 commit intomasterfrom
exec-security-docs
Jun 26, 2019
Merged

docs(exec): document security concerns#950
nfischer merged 1 commit intomasterfrom
exec-security-docs

Conversation

@nfischer
Copy link
Copy Markdown
Member

@nfischer nfischer commented Jun 26, 2019 •
edited
Loading

No change to logic.

This adds documentation about shell.exec()'s inherent vulnerability to
command injection and links to a more detailed security notice.

Issue #103, #143, #495, #765, #766, #810, #842, #938, #945

@nfischer nfischer added docs exec Issues specific to the shell.exec() API security labels Jun 26, 2019
@nfischer
docs(exec): document security concerns
e63899d 
No change to logic.

This adds documentation about `shell.exec()`'s inherent vulnerability to
command injection and links to a more detailed security notice.

Issue #103, #143, #495, #765, #766, #810, #842, #938, #945
@nfischer nfischer force-pushed the exec-security-docs branch from ce0ef4f to e63899d Compare June 26, 2019 09:13
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 26, 2019 •
edited by codecov Bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.28%. Comparing base (619d234) to head (e63899d).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #950   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files          34       34           
  Lines        1290     1290           
=======================================
  Hits         1255     1255           
  Misses         35       35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nfischer nfischer merged commit 68c3822 into master Jun 26, 2019
nfischer added a commit that referenced this pull request Jun 26, 2019
@nfischer
docs(exec): minor wording changes on security doc
c43642b 
This is a follow-up to #950, to emphasize the message.
@nfischer nfischer mentioned this pull request Jun 26, 2019
Merged
@nfischer
Copy link
Copy Markdown
Member Author

nfischer commented Jun 26, 2019

I realized "avoid command execution" should be "avoid command injection" - sent out #951 to address this.

@nfischer nfischer deleted the exec-security-docs branch June 26, 2019 15:24
nfischer added a commit that referenced this pull request Jun 26, 2019
@nfischer
docs(exec): minor wording changes on security doc (#951)
7aa8ce4 
This is a follow-up to #950, to emphasize the message.
@nfischer nfischer mentioned this pull request Jun 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs exec Issues specific to the shell.exec() API security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nfischer @codecov-io