Conversation
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
=========================================
+ Coverage 95.39% 95.4% +<.01%
=========================================
Files 33 33
Lines 1239 1241 +2
=========================================
+ Hits 1182 1184 +2
Misses 57 57
Continue to review full report at Codecov.
|
nfischer
approved these changes
Oct 13, 2017
Member
nfischer
left a comment
nfischer
left a comment
There was a problem hiding this comment.
Any noticeable performance hit by adding an extra function call?
Contributor
Author
|
It's doubtful. I think V8 will just inline the functions anyway. |
This was referenced Aug 29, 2019
This was referenced Mar 24, 2020
This was referenced Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #745
Adds two new methods to
src/common.js,common.statFollowLinksandcommon.statNoFollowLinks, which wrapfs.statSyncandfs.lstatSync, respectively. This change is meant to improve readability and clarify intent.