Conversation
This sets 2 AVA options: * `serial`: same behavior as the CLI flag, which this replaces * `powerAssert`: if an assert fails, it will inspect all objects involved in the failed assert. This causes readability issues if `t.falsy(shell.error())` breaks, since it inspects all of `shell` (which is way too large). AVA options are a little easier to manage than CLI options (we only update one place instead of 2 in `package.json`).
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 33 33
Lines 1237 1237
=======================================
Hits 1180 1180
Misses 57 57Continue to review full report at Codecov.
|
freitagbr
approved these changes
Oct 13, 2017
Contributor
freitagbr
left a comment
freitagbr
left a comment
There was a problem hiding this comment.
LGTM. I'd rather have verbose test output (with powerAssert) than too little information to debug with.
Member
Author
|
The output is still improved over previous AVA output (it's pretty good). It's just catastrophically verbose with the |
This was referenced Aug 29, 2019
This was referenced Mar 24, 2020
This was referenced Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets 2 AVA options:
serial: same behavior as the CLI flag, which this replacespowerAssert: if an assert fails, it will inspect all objects involved inthe failed assert. This causes readability issues if
t.falsy(shell.error())breaks, since it inspects all of
shell(which is way too large).AVA options are a little easier to manage than CLI options (we only update one
place instead of 2 in
package.json).