Conversation
This adds a test for `head()` on the right-hand side of a pipe. This also removes the try-catch surrounding `fs.openSync()`, because it was unreachable code. `fs.existsSync()` guarantees that the file exists, and `fs.openSync()` only throws if the file does not exist, according to official documentation. Fixes #671
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
==========================================
+ Coverage 96.65% 96.89% +0.23%
==========================================
Files 33 33
Lines 1227 1224 -3
==========================================
Hits 1186 1186
+ Misses 41 38 -3
Continue to review full report at Codecov.
|
Member
Author
|
No functional change, so self-LGTM |
This was referenced Aug 29, 2019
This was referenced Mar 24, 2020
This was referenced Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test for
head()on the right-hand side of a pipe. This alsoremoves the try-catch surrounding
fs.openSync(), because it was unreachablecode.
fs.existsSync()guarantees that the file exists, andfs.openSync()only throws if the file does not exist, according to official documentation.
I see 100% line coverage for
src/head.jswhen running:$ nyc --reporter=text --reporter=lcov ava --serial test/head.js`Fixes #741