fix(ls): properly handle symlinks without a trailing slash on macOS #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nfischer: You have a windows machine, right? |
Member
|
@ariporad This breaks compatibility with unix > exec('ls file.txt');
file.txt
> ls('file.txt');
ls: no such file or directory: file.txtThis bug is not visible on the master branch of ShellJS. We should probably add tests for |
Contributor
Author
|
Hmm... Maybe we should just file a bug in node for this... It doesn't really seem like our problem |
Member
|
Whether or not this is an issue we should address, it seems clear that this approach isn't the right way to address this. @ariporad If you think this is a bug with node's core, feel free to file a report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really cheap hack, but it works.
Fixes #446.