chore(make): depreciate shelljs/make #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make.js
Outdated
| require('./global'); | ||
|
|
||
| console.log('WARNING: shelljs/make is deprecated, and will be going away soon. You should upgrade ' + | ||
| 'your code to stop using it. You should also submit feedback at https://git.io/vwgId.'); |
Member
There was a problem hiding this comment.
Could we use the full URL? The shortened URL may appear as less trustworthy.
Member
|
@ariporad I updated the warning output to be a little more concise. I took out the URL, since I'm sure if someone has a concern, they can just post an issue and we can redirect the conversation to the original thread. |
Contributor
Author
|
LGTM! |
|
Why is make functionality being deprecated? |
Member
|
@timburgess Please take a look at #340 and we'll continue the conversation there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.