feat(exec): allow all exec options to pass through #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfischer
force-pushed
the
more-exec-options
branch
from
9bd96a4 to
f5e5241
Compare
nfischer
force-pushed
the
more-exec-options
branch
from
f5e5241 to
058bb67
Compare
| `true`, regardless of the passed value. | ||
| + `silent`: Do not echo program output to console. | ||
| + and any option available to NodeJS's | ||
| [child_process.exec()](https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback) |
Contributor
There was a problem hiding this comment.
Why is this on a seperate line?
Member
Author
There was a problem hiding this comment.
@ariporad I try to format lines to be under 80 characters. This is how vim's built-in formatting did it. Markdown allows you to extend lines (as long as you don't leave one blank line in-between) without it affecting the end-result. You can check "view file" to be sure
Contributor
|
@nfischer: A few small comments, otherwise looks good! |
This was referenced Feb 4, 2016
Member
Author
|
@ariporad this should be good now |
Contributor
|
LGTM! |
ariporad
added a commit
that referenced
this pull request
Feb 4, 2016
feat(exec): allow all exec options to pass through
This was referenced Feb 9, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows any option from https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback to be passed through our
shell.exec()function to the nativeexec()/execSync().This fixes #250, #132 and replaces #270 #284 #333 #163
This specifically tests the
cwd,maxBuffer, andtimeoutoptions, since those were requested.