refactor: avoid dependency cycle #1204
Merged
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, there was a dependency cycle between shell.js and common.js. This refactors code to avoid the cycle. This was previously reported in #1133. Node.js already worked around the issue in v20.6.1, but it's simpler if we can avoid the dependency cycle on our end anyway. I tested this with `npm test` and also by running my own script which uses a shelljs plugin. This seems to work correctly in both cases.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 35 35
Lines 1408 1410 +2
=======================================
+ Hits 1371 1373 +2
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, there was a dependency cycle between shell.js and common.js. This refactors code to avoid the cycle.
This was previously reported in #1133. Node.js already worked around the issue in v20.6.1, but it's simpler if we can avoid the dependency cycle on our end anyway.
I tested this with
npm testand also by running my own script which uses a shelljs plugin. This seems to work correctly in both cases.