feat: expose new shell.cmd() #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfischer
added
feature
exec
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1185 +/- ##
==========================================
+ Coverage 97.28% 97.38% +0.09%
==========================================
Files 36 36
Lines 1364 1452 +88
==========================================
+ Hits 1327 1414 +87
- Misses 37 38 +1 ☔ View full report in Codecov by Sentry. |
shell.cmd() was originally implemented in #866, however was not yet exposed. This command should be ready for people to try out, so this exposes the command by default. This is still not a full implementation of everything in the https://shelljs.page.link/cmd-design design doc, however this completes the initial phase and is likely good enough to replace most use cases of synchronous shell.exec(). Fixes #495
nfischer
force-pushed
the
feat-expose-cmd
branch
from
daaedf1 to
c0fa2c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shell.cmd() was originally implemented in #866, however was not yet exposed. This command should be ready for people to try out, so this exposes the command by default.
This is still not a full implementation of everything in the https://shelljs.page.link/cmd-design design doc, however this completes the initial phase and is likely good enough to replace most use cases of synchronous shell.exec().
Fixes #495