test: add test coverage for some globOptions#1163
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1163 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 36 36
Lines 1360 1360
=======================================
Hits 1323 1323
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nfischer
force-pushed
the
test-glob-opts
branch
4 times, most recently
from
e4e6753 to
989d34f
Compare
No change to logic. This adds test coverage support for all of the globOptions which share the same name between node-glob and fast-glob. See https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-glob Issue #828
nfischer
added a commit
that referenced
this pull request
Jun 14, 2024
No change to logic. This adds tests for more `config.globOptions` values. This aims to cover the options which appear to be supported by both node-glob and fast-glob, however the options have different names in each module. This is a followup to PR #1163. See https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-glob Issue #828
nfischer
added a commit
that referenced
this pull request
Jun 14, 2024
No change to logic. This adds tests for more `config.globOptions` values. This aims to cover the options which appear to be supported by both node-glob and fast-glob, however the options have different names in each module. This is a followup to PR #1163. See https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-glob Issue #828
nfischer
added a commit
that referenced
this pull request
Jun 14, 2024
No change to logic. This adds tests for more `config.globOptions` values. This aims to cover the options which appear to be supported by both node-glob and fast-glob, however the options have different names in each module. This is a followup to PR #1163. See https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-glob Issue #828
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No change to logic. This adds test coverage support for all of the globOptions which share the same name between node-glob and fast-glob.
See https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-glob
Issue #828